Asterisks in "Unsaved Changes" Messages have Dotted Underline

Patch #50 applied successfully on 10.1.x-dev. Patch fixes the issue.
Screenshot same as #51.

RTBC+1

Can the issue summary steps be updated?

Tried testing on drupal 10.1 with an Umani theme and could not replicate.

Tried testing on drupal 10.1 with an Umani theme and could not replicate.

Use starterkit_theme or Umami as admin theme & Visit /admin/structure/types/manage/page/display

Try to re-arrange the order then you will see Asterisks in "Unsaved Changes" Messages have Dotted Underline

Just tested on a fresh install of umami at the exact url provided. No underline.

I have added a screen-recording for reference. please check if it helps.

I am using Umami as admin theme here.

Since this seems to only seems to trigger when umami is used as an admin theme, will lean on the framework manager to decide.

Since this seems to only seems to trigger when umami is used as an admin theme, will lean on the framework manager to decide.

This is happening with Starterkit theme as well.

As per comment #59 updating the patch for Olivero theme as well

I have reviewed the patch on comment number #61 working fine attaching the screenshot of that but test cases are getting failed @aziza_a can you please check and fix it.

Updated as per comment #63

Verified the patch #64 on Drupal version 10.1.x with Olivero theme. Patch applied cleanly and can confirm that the issue is fixed for Olivero theme. Screenshot attached for reference.

This patch seems to fix the issue, however are we _sure_ we want to fix the issue?

If you check in /core/themes/stable9/css/core/assets/vendor/normalize-css/normalize.css on lines 80-89, we have this:

/**
 * 1. Remove the bottom border in Chrome 57-
 * 2. Add the correct text decoration in Chrome, Edge, IE, Opera, and Safari.
 */

abbr[title] {
  border-bottom: none; /* 1 */
  text-decoration: underline; /* 2 */
  text-decoration: underline dotted; /* 2 */
}

For me, this seems like we are making a deliberate decision to override normalize.css and remove their suggestion of underlining the title. Honestly, i don't have a problem with this and it certainly seems to look much better with the patch from #64 applied. I guess in our case we are deciding to use an * instead of an underline.

I'm going to RTBC this for now, while we wait for a framework manager to make the final decision.

Fixing tag.

If this only happens when you're using frontend themes as admin themes, my inclination is to mark it as closed works as designed, but will defer to frontend framework managers.

The last submitted patch, 64: 3180992-64.patch, failed testing. View results →

I have created this patch for 10.1.x-dev olivero theme and its working fine. Please verify.

Setting back to 'Needs review' to see if #64 passes, but also so we might get some feedback from a frontend framework manager given our concerns from #68 and #69

Hi,

Verified patch #64 on Drupal version 10.1.x with the Olivero theme. The patch applied cleanly, and I can confirm that the issue is fixed for the Olivero theme. I have attached a screenshot for reference.

Added wrong SS replacing new SS

Great, thanks @nilesh.k

Let's move this back to RTBC pending a frontend framework manager review to check the comments in #68 and #69

Thanks folks for working on this. It is a bug and I don't think it needs to be wontfix. I also don't think we need the FEFMs to tell us whether such a small bug should be fixed or not. I think what we actually need is an Olivero maintainer's review. :)

Also, we shouldn't RTBC things that aren't actually committable. It's okay to RTBC it with "Needs X manager review" if it is otherwise committable (passing tests, peer-reviewed, has consensus, etc.).

The patch in #71 has real failures and does not need to be retested a thousand times; it needs to update the PostCSS and have the CSS recompiled. →

The merge request also appears to be older than most of the patches, and should be closed if it is outdated. We really shouldn't post patches, then merge requests, then more patches. It creates a lot of confusion.

Thanks!

Fixed the build error in #64, attached interdiff for same.

Thanks @Gauravvvv!

I still need someone to close the merge request if it's irrelevant, or if they don't have permission, to state unequivocally that the MR is defunct (and why we switched back to patches) so that I can close it myself. Thanks!

Believe the MR is probably stale at this point.

But how come #71 was skipped for #64?

Also @larowlan posted

If this only happens when you're using frontend themes as admin themes, my inclination is to mark it as closed works as designed, but will defer to frontend framework managers.

Just a note for anyone reading this/working on this. The conversation seems to have moved towards talking about Olivero, but this issue/patch is for Olivero and Umami theme and starterkit_theme.

That said, "works as designed" seems the right status for this.

Both @larowlan (Framework manager) and @markcontroy (Umami submaintainer) both seemed to think this is working as designed.

If any strong disagreement please reopen explaining why.