Support path patterns in the Hardering Plugin

Created on 29 May 2020, about 4 years ago
Updated 31 January 2023, over 1 year ago

Problem/Motivation

Currently the VendorHarderingPlugin allows to provide a list of directories to clean on each package like:

"extra": {
  "drupal-core-vendor-hardening": {
    "vendor/package": ["test", "documentation"]
  }
}

However in certain cases we want to remove several directories which match a certain pattern (e.g. tests directories) in which case we currently need to maintain an extensive list of directories.

Proposed resolution

Use glob() function to resolve the patterns and iterate over the directories returned by this function.

✨ Feature request
Status

Needs work

Version

10.1 ✨

Component
BaseΒ  β†’

Last updated 1 minute ago

Created by

πŸ‡΅πŸ‡ͺPeru piggito

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • Needs framework manager review

    It is used to alert the framework manager core committer(s) that an issue significantly impacts (or has the potential to impact) multiple subsystems or represents a significant change or addition in architecture or public APIs, and their signoff is needed (see the governance policy draft for more information). If an issue significantly impacts only one subsystem, use Needs subsystem maintainer review instead, and make sure the issue component is set to the correct subsystem.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request β†’ as a guide.

    Not sure how this survived the review bot.

    But it will require tests to show of this new feature

    Tagged for framework manager to see if it's something we should not do.

Production build 0.69.0 2024