- last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Patch Failed to Apply - ๐บ๐ธUnited States utcwebdev
#19 patch fails to apply in Drupal 10.1.6 (see new test).
https://www.drupal.org/project/drupal/issues/3133639#comment-14119137 ๐ Fix Claro styles for exposed views filters wrapped in fieldsets Needs work - last update
about 1 year ago Patch Failed to Apply - Status changed to Needs review
about 1 year ago 3:12am 2 November 2023 - ๐ฎ๐ณIndia gauravvvv Delhi, India
I have attached the patch for 11.x Patch #32, no longer applies so not adding the interdiff
- last update
about 1 year ago Composer error. Unable to continue. - last update
about 1 year ago Custom Commands Failed - Status changed to Needs work
about 1 year ago 3:17pm 2 November 2023 - ๐บ๐ธUnited States smustgrave
IS seems to contain a number of TBD that should be addressed.
- last update
about 1 year ago Custom Commands Failed - last update
about 1 year ago 30,485 pass - last update
about 1 year ago 29,678 pass - last update
about 1 year ago 30,530 pass - ๐ฎ๐ณIndia prashant.c Dharamshala
Prashant.c โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia prashant.c Dharamshala
Changes provided in the patches fixing the issue, removed duplicate code from the https://git.drupalcode.org/project/drupal/-/merge_requests/5811.
Keeping the MR in draft as there is still some work mentioned in #38 ๐ Fix Claro styles for exposed views filters wrapped in fieldsets Needs work .
Thanks
- ๐ฎ๐ณIndia gauravvvv Delhi, India
I have updated logical properties in merge request !5811
- ๐ซ๐ฎFinland sokru
Based on MR 1134, I added two improvements:
1. Fix alignment of grouped radio filters mentioned on #31
2. Move multi-select operator to top of flex element.Before:
After:
- ๐ช๐ธSpain ckrina Barcelona
As commented on Slack, this is more complex that it looks like. We're giving the option to add things to a place that is not designs to have them. If you want to have a field with 5 radio buttons, a top bar that is supposed to have horizontal things aligned is not its place. Basically, if we want to convert this search section in a box where anything can be thrown at, thatโs not the place. We would need a classic vertical search section or any other modern pattern we can think of. But the top section if designed for quick and simple filters: takes fewer space and it's quick to access.
So my recommendation would be to totally rethink how we give people options, in a way that we can also recommend where to place them and provide that alternative place for complex search. Obviously it's out of scope here, but it's important to point out that this change is breaking the UX.
That said, here are a few design recommendations to make it look less bad in with fields that can be horizontally aligned:
- Horizontally align items
- Adjust field widths
- Reduce spacing between elements within the same fieldset (4px)
- Remove the visual border of the fielset/details
- Increase space between all elements in this specific area if there are fieldsets/details inisde (easily done with CSS :has) and set a separation of 24px
So from this example:
Would become:
Design can't solve much more beyond this. Things like #45 just shouldn't be done in here.