- 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
per #9 going to 9999 is too high. Whatever version is decided and why should be added to the issue summary please.
- 🇮🇳India gauravvvv Delhi, India
Currently
.ui-dialog
have a z-index of 1260. As suggested in #9, we can have z-index as 1500.--jui-dialog-z-index: 1260; .ui-dialog { z-index: var(--jui-dialog-z-index); }
- Status changed to Needs review
almost 2 years ago 5:48am 14 February 2023 - 🇮🇳India gauravvvv Delhi, India
Updated issue summary and attached patch with interdiff for same. please review
The last submitted patch, 22: 3118813-22.patch, failed testing. View results →
- Status changed to Needs work
almost 2 years ago 8:00pm 15 February 2023 - 🇺🇸United States smustgrave
#9 mentioned adding some research to land on 1500. Can you provide what that was and add to the IS please.
- Status changed to Needs review
almost 2 years ago 4:50am 16 February 2023 - 🇮🇳India Abhisheksingh27
Adding reroll for 10.1.x as above patch failed on 10.1.x.
Removed changes of "b/core/themes/stable/css/system/components/ajax-progress.module.css" because it doesn't exist in 10.1.x - Status changed to Needs work
almost 2 years ago 2:03pm 16 February 2023 - 🇺🇸United States bnjmnm Ann Arbor, MI
Tagging with Field UX as upcoming changes will potentially add more usages of ajax progress in dialogs.
- First commit to issue fork.
- @utkarsh_33 opened merge request.
Setting the z-index for .ajax-progress--fullscreen class to 1300 because the z-index for .ui-dialog class is 1260 and any thing which is above 1260 shall work.You can find the z-indexes in drupal → for reference.
- Status changed to Needs review
over 1 year ago 3:50am 12 April 2023 - Status changed to RTBC
over 1 year ago 4:26pm 12 April 2023 - 🇺🇸United States smustgrave
Thank for the reasoning. Added that to the issue summary too
- last update
over 1 year ago 29,202 pass - Status changed to Needs work
over 1 year ago 5:54pm 17 April 2023 - 🇺🇸United States bnjmnm Ann Arbor, MI
Re #31
Setting the z-index for .ajax-progress--fullscreen class to 1300 because the z-index for .ui-dialog class is 1260 and any thing which is above 1260 shall work.You can find the z-indexes in drupal for reference.
Based on this rationale, the z-index should be 1261 then as we want to avoid z-index creep. Either the z-index or the explanation should be modified.
- last update
over 1 year ago 29,283 pass - Status changed to RTBC
over 1 year ago 1:35pm 18 April 2023 - 🇺🇸United States tim.plunkett Philadelphia
Good suggestion @bnjmnm, thanks @Utkarsh_33 for the prompt change
- last update
over 1 year ago 29,283 pass - last update
over 1 year ago 29,302 pass - last update
over 1 year ago 29,304 pass - last update
over 1 year ago 29,304 pass - last update
over 1 year ago 29,304 pass -
bnjmnm →
committed 0a32294b on 10.1.x authored by
Utkarsh_33 →
Issue #3118813 by Utkarsh_33, GuyPaddock, Gauravvvv, Abhisheksingh27,...
-
bnjmnm →
committed 0a32294b on 10.1.x authored by
Utkarsh_33 →
- Status changed to Fixed
over 1 year ago 6:36pm 24 April 2023 - 🇺🇸United States bnjmnm Ann Arbor, MI
Tested manually with every core theme. This is fixed where it needs to be fixed, and doesn't introduce changes where nothing needs to be fixed. Committed to 10.1.x.
Automatically closed - issue fixed for 2 weeks with no activity.