Replace REQUEST_TIME in Kernel tests

Updated title as we created another issue for Replacing REQUEST_TIME in Functional/FunctionalJavascript tests

Uploaded current changes to 10.0.x as patch before rebasing to 11.x branch.

@alexpott made below comment on MR #2753

I think we should use \Drupal::time()->getRequestTime() and be done... it's better than another property on the test class.

So we might need to replace all usages of $this->requestTime with \Drupal::time()->getRequestTime()

The patch #50 has error to be applied, I recreated based to version 10.0.x.

Patch was moved to an MR. Repostponing on 📌 Replace REQUEST_TIME in Functional and FunctionalJavascript tests Needs work

Any reason it postponed on other conversion?

There's still a huge number of changes to non Kernel/Unit test files here. All functional/functionaljs tests are being updated in 📌 Replace REQUEST_TIME in Functional and FunctionalJavascript tests Needs work

Peeled this back to just Kernel tests and removed the class members entirely. Used variables for $requestTime where appropriate. Pipeline is green :)

No need for a CR now since we're not adding any class members.

Could issue summary and title be updated too please

modules/dblog/tests/src/Kernel/DbLogTest.php
modules/views/tests/src/Kernel/RenderCacheIntegrationTest.php

Found 2 more.

Those 2 come from traits which we're not fixing here (FakeLogEntries and AssertViewsCacheTagsTrait)

If you search the test files you'll see that there are no references to REQUEST_TIME. The traits are fixed in the functional test one I believe.

Thanks for confirming @acbramley

Looks fine except for one change I didn't understand.

Committed/pushed to 11.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.