Replace REQUEST_TIME in Functional and FunctionalJavascript tests

Bhanu951 → closed merge request !4316

Created New MR #4317 against 11.x Branch and Removed testRequestTime property and used drupal time in remaining places.

Left a comment but the issue summary mentions this should be FunctionalJavascript file but the MR I see 1 FunctionalJavascript file changed. So MR and issue summary don't line up.

@smustgrave

I ran grep -R "REQUEST_TIME" core >list.txt and found no additional FunctionalJavascript tests with REQUEST_TIME.

So, The title seems correct.

In that case the changes to the functional tests should be reverted as they would be out of scope

@smustgrave

Seems you got confused, this issue is to fix both Functional and FunctionalJavascript tests. So back to NR.

Applied the MR and searched phpstan-baseline for REQUEST_TIME which had 59 matches. None for Functional or FunctionalJavascript files.

This needs a reroll.

I skimmed both MR and I am not convinced that the comments by alexpott in the first MR have been addressed and answered. The proposed resolution is a bit different than what it implemented. It looks like the proposed resolution was for when a new property was being added.

I've updated the remaining tasks. Back to NW.

Feedback addressed, pipeline's green again. Hiding the old MR.

acbramley → changed the visibility of the branch 3309104-replace-requesttime-in to hidden.

Applied the MR

Searching phpstan-baseline remaining REQUEST_TIME and all instances of FunctionalJavascript and Functional appear to be replaced.

One question on the MR, everything else looks good.

Believe the one thread from @catch has been answered.

Let's add a comment explaining what's happening there.

acbramley → credited mstrelan → .

Going to self RTBC since this was a simple change and we went with @mstrelan's version.

Committed/pushed to 11.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.