Base field filter operators do not include "Is empty (NULL)" and "Is not empty (NOT NULL)"

let's try with latest 10.1 to "gain attention"

Rebased the PR and updated with tests for checking "allow empty" option for not required fields.

Will need a 11.x branch as that's the latest development branch.
Recommend starting a new one.

Also think the issue summary could use some love. Recommend adding the default template.

Updates:
- Create new MR for 11.x branch
- Update issue summary

so i think we're back to Needs Review.

Confirmed the MR addresses the Null and Not Null options are available for the filename.

May need a change record but will see if the committer agrees.

Doing RTBC issue triage.

I read the IS and used the steps to reproduce and successfully confirmed the problem. Since this is a change to the user interface there should be screenshots linked to in the Issue Summary. I read the comments and do not see any comment saying that the code and test were reviewed. I also wonder if the test fails without the fix.

Regarding a change record, yes add one. This is for views which is an interface with many, many options so we should let everyone know about it. The CR should have screen shots.

Setting back to NW.

Adding link to Documentation Gate about when to add change records, https://www.drupal.org/about/core/policies/core-change-policies/core-gat... →

Updates:
- screenshots for issue summary
- patch with tests only for seeing ... it fails.

The last submitted patch, 28: 3098560-test-to-fail.patch, failed testing. View results →

Failed asserting that an array has the key 'allow empty'.
And the patch with tests without "fix" fails ... as intended

So it think we're back to RTBC

The last submitted patch, 28: 3098560-test-to-fail.patch, failed testing. View results →

"Remove" the patch with tests without "fix" ... so it wouldn't change the issue status ... no more

@vasike, thank you for doing that last bit of work.

There are comments that this patch works, although not for boolean but that makes sense to me. What I still do not see is that anyone has reviewed the code. I scanned it but I don't know enough of views to do a proper review. I have added that to the IS in the remaining tasks.

I updated credit but, as always, it needed to be checked by the committer.

Change seems small and addresses the issue.

Am curious why this just appears on file views outside the core one.

Adding a patch version of the MR for composer patching.

Overlaps with 📌 Add 'Is empty (NULL)' and 'Is not empty (NOT NULL)' operators to boolean field filtering Needs work

Nice work on this! I posted a couple small nitpick suggestions on the MR.

I also think this should maybe have some UI test coverage, in addition to the kernel test coverage that's being added already?

Can someone test if 📌 Add 'Is empty (NULL)' and 'Is not empty (NOT NULL)' operators to boolean field filtering Needs work solves the issue here? If not what should be addressed here that isn't addressed other there.

@smustgrave it's not the same ... it should be clear from issue summary - User interface changes section
So this is about missing those options ... the other issue it's about their actually filtering ...

Anyway updated the MR with latest 11.x and also checked the tests ... they fail without the fix.

So I think this should be back on track.

I've tested https://git.drupalcode.org/project/drupal/-/merge_requests/4060 and it worked very well!