Plugin blocks cannot set their own attributes when put in the layout

As mentioned in #29 the MR seems to be missing some files. And there is an open thread on the 1 file added.

I've removed duplciate for this line below.

$build['content'] = $content;

Besides, the tests from #13 🐛 Plugin blocks cannot set their own attributes when put in the layout Closed: duplicate are already in drupal core 9.3.x, so that's why you don't see new files in the MR.

I've also created a static patch for those who does not like when patch from MR does not apply anymore due to new commits.

So if the tests were already added and they didn't catch this bug then I think the tests may not have been covering this bug. So we will need a failing test case to show this is still an issue I believe.

@smustgrave, you can check #2 comment, there are two patches, first patch contains only tests without the fix and it failed, second patch contains the fix + tests and it successed.

Would you expect to have one more test scenario that will fail, something like this?

$assert_session->elementNotExists('css', '.attribute-test-class');
$assert_session->elementNotExists('css', '[custom-attribute=test]');
$assert_session->elementNotExists('css', 'div[data-contextual-id*="layout_builder_test"]');

So if the fix is not working then test will be passed.

I'm not sure what else we can add here

I think #2 was just overlooked. Setting it back to NR for that matter.

The test-only patch from #2

One file is already in drupal core
The other is not but also contains deprecated function calls.

The MR and patch #34 do not contain any tests. Would expect a full patch to contain the tests also.

@smustgrave, you can find that the tests exist and already commited in 9.2.x, 9.3.x almost 2 years ago.

#3020876-68: Contextual links of reusable content blocks are not displayed when rendering entities built via Layout Builder → ,

that why you can't see tests in the MR.

Then the tests weren't covering this bug or they would be failing on without this fix. So either this is a non issue now or we need new tests.

Indeed, it's very confusing issue due to mix from 🐛 Contextual links of reusable content blocks are not displayed when rendering entities built via Layout Builder Needs work .

See #3020876-29: Contextual links of reusable content blocks are not displayed when rendering entities built via Layout Builder → , now I'm surprised that this issue even exists, seems like it should be fixed in #3020876.

Thoughts?

Can you see if the fix from that one solves the problem here? Could be the same issue and just 2 different approaches being taken.

Posted in the #bugsmash channel on slack too

It's indeed seems like a duplicate of 🐛 Contextual links of reusable content blocks are not displayed when rendering entities built via Layout Builder Needs work , the only difference is that here we have an extra condition

if (!$is_content_empty) { }

Honestly, that extra condition does not affect on functionality, at least the tests that cover block attributes change from 🐛 Contextual links of reusable content blocks are not displayed when rendering entities built via Layout Builder Needs work are passed.

I would closed this as duplicate, but I need one more confirmation of this theory

Looking at this again I do think it's a duplicate. Closing this out for the other and will move over credit.

Thanks!