Views blocks that are disabled should not appear in block UI/layout builder

Updated in such a way that the disabled blocks wont appear on add new block UI/layout, but existing added blocks will appear as such in UI.

@sijumpk I tried With the MR !6287 - 11.x and also 3076346-views-blocks-that
The issue is not resolved.

Testing steps :
1. Add a block , and individual blocks
2. disabled individual block
3. This block still appears in block UI or layout builder.

@divya.sejekan, In order to see the updated list after disabling the block, you should reloaded blocks UI page or reopened the "Place block" popup after closing it.

This will need a failing test to show the issue.

Issue summary also needs to be updated to use the standard issue template.

Did not test.

Added standard template and updated issue summary.
Thanks

Added failing test as patch file, disabled_views_block_failing_test.patch →

Have not reviewed. Still appears to need an issue summary update. No need to add a failing patch, there's the test-only feature of the MR.

Problem/Motivation

Disbled block type displays of views appears in block UI/layout builder adding list.

Steps to reproduce

1. Create a standard D11 installation
2. Go to Content view edit page (admin/structure/views/view/content)
3. Add a Block type display to the view and rename it "Test block"
4. In the view edit page disable the block by cliking "Disable Test block" link
5. Save the view
6. Go to Claro's Block layout page (admin/structure/block/list/claro)
7. Click on "Place block" button for any region
8. Our disabled block, "Test block", appears in the list

Proposed resolution

Hide disabled view blocks from the block adding list.

Merge request link

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Running the test-only feature though shows the test is passing without the fix. https://git.drupalcode.org/issue/drupal-3076346/-/jobs/697927

The error fixing portion is reverted back, and now there is just the test in the current MR. You can see that its getting failed with the desired error message. https://git.drupalcode.org/issue/drupal-3076346/-/jobs/762582.

So technically the test-only feature should also have to fail. How can this be possible? I also did a rebasing this time, maybe that helped. Anyway if you can check the current failed MR and confirm about the test case, I will add back the fix to the MR.

Tried removing the problem fixing portion from the code, leaving test only in MR. By doing so the MR got failed with the desired error message. You can see the job results here

https://git.drupalcode.org/issue/drupal-3076346/-/jobs/762582

Now the fix is added back to the code, and MR is getting completed without errors. No idea how the test-only pipeline got passed last time. Now I have rebased the code also, so this time lets hope test-only will work as expected.

Hi All,

After MR !6287, The test block hide from Place block option,
But i also tested the issue by following Steps

1. Create a standard D11 installation
2. Go to Content view edit page (admin/structure/views/view/content)
3. Add a Block type display to the view and rename it "Test block"
4. In the view edit page disable the block by cliking "Disable Test block" link
5. Save the view
6. Go to Claro's Block layout page (admin/structure/block/list/claro)
7. Click on "Place block" button for any region
8. Our disabled block, "Test block", appears in the list

User can place the block after disable block in view, but block not appears in any page. maybe i miss some step.

sijumpk → changed the visibility of the branch 3076346-views-blocks-that to hidden.

sijumpk → changed the visibility of the branch 11.x to hidden.

Had committed the problem fixing code to 11.x branch, because of that the test-only pipeline was not showing any problem. Now 11.x is reverted back to its original state and added changes (the fix and updated test) to a separate branch. Here is the test result for test-only pipeline https://git.drupalcode.org/issue/drupal-3076346/-/jobs/806000. And its getting failed as expected. Please review it.

Sorry re-read the title and just realized this was also mentioning layout builder. Think we need to add test coverage there as well. Maybe can extend existing to check the list but in layout builder.

That test should be in layout builder module though.

@smustgrave, it was a point worth watching. I missed that portion and Layout builder is using its own logic to list the blocks. Now its fixed and also a test case for that added to an existing test file.

Believe this covers both scenarios now

Left feedback on the MR.