Remove unused function getSchemaUpdates()

This function is still in Drupal 10.1.x-dev, see: https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/lib/Drupal/Core/Updater/Module.php#L84

It seems like it has no direct usages in D10 as well. We need to probably clarify the purpose of this function to decide.

Searching the repo I can't find any reference.

Searched http://grep.xnddx.ru/search?text=getSchemaUpdates&filename= and also didn't find any reference. Probably safe to remove as dead code.

Here's a patch to remove unused code as i cannot find any reference in the core as well.

Lets see what the committer says.

Before removing something that's unused, we should check whether it's used in contrib (in this case no), but also why it's unused.

I ran git log -S getSchemaUpdates and the last mention was

commit 368cf30de0237484dd8eef86069b6649faf66347
Author: webchick <webchick@24967.no-reply.drupal.org>
Date:   Sat Mar 10 16:23:05 2012 -0800

    Issue #1471376 by amateescu: Convert updater.inc to PSR-0.

I went back to the first mention:

git show 6abcc47e25e936aea8 | grep getSchemaUpdates

And it shows the method being added but no usages.

As far as I can tell this was unused when it was added in 2009 and we've just been occasionally moving it around since.

However, it's a public method on a core class so I think we should deprecate it first.

I will work on it.

Hi I deprecated the method and also created a change record, please

https://www.drupal.org/node/3359445 →

If we are going to deprecate it think we should also add trigger_error for it.

Should follow how other methods are deprecated

@trigger_error(__METHOD__ . '() is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. There is no replacement. See https://www.drupal.org/node/3337942 → ', E_USER_DEPRECATED);

unpublished CR, it needs deprecation test additionally to #16 https://www.drupal.org/about/core/policies/core-change-policies/drupal-d... →

We don't need a deprecation test unless there's an actual bc layer with logic in it or similar, when the deprecation is 'just' the phpdoc and trigger_error() we can skip testing for those.

Trigger_error looks good, right version.

CR reads well and is with the right branches.

Think this is good to go.

I think this should just be deprecated with no replacement, it's not replaced by hook_update_N(), it's about finding out whether a module has updates that need to be run. No-one is likely to use this since it's very internal to core (except maybe drush but they won't be using this either).

Or we could point people to \Drupal::service('update.update_hook_registry')->getAvailableUpdates

I went with giving people an option, to use \Drupal::service('update.update_hook_registry')->getAvailableUpdates. I also updated the CR.

Thanks that looks good, back to RTBC.

Using MR, RTBC++

longwave → credited karolinam → .

Crediting @karolinam as requested in the IS.

Committed 8e42cef and pushed to 11.x. Thanks!

Also published the change record.

Automatically closed - issue fixed for 2 weeks with no activity.