We are working on this issue at DrupalCon Portland 2024
Fixed in 23ae4d8d. Thanks!
Somehow I did not seem to have permissions to push to the issue fork (search_api_fusion-3413577) so I had to push directly to 2.0.x.
Pushed 2c5f9721 along with 5d9c6851 which makes the module incompatible with drupal 9 since Error::logException() was only introduced in drupal 10
https://www.drupal.org/node/2932520 →
Made new RC https://www.drupal.org/project/search_api_fusion/releases/2.0.0-rc1 →
I have scanned components 8.x-2.4 with Upgrade Status → . The report shows 4 errors, which are all addressed by MR !35:
Thanks! Attached is a static copy of MR !35 so it can be easily referenced in composer.json.
Patch does not apply anymore against 8.x-3.x -- re-rolled
Confirmed this patch brings supports for Drupal 10 and works as expected.
Any chance this can be rolled into a new stable release ? Drupal 9 is end of life since Nov 1st 2023 https://www.drupal.org/docs/understanding-drupal/drupal-9-release-date-a... →
#3 works fine -- thanks!
With regards to setting the urlPrefix to https://x.com instead of https://www.twitter.com/ -- I believe this would prevent users from re-saving existing URLs (they would have to update the links from x.com to twitter.com upon saving the form), which may be annoying.
Also x.com currently redirects to twitter.com so people may have a hard time generating URLs with x.com.
An alternative is to create a new, distinct social network X on top of Twitter so end users would be able to choose whether they want their link to be rendered with the bird icon or with an X. The domain constraint would match the network they pick.
karolinam → credited fengtan → .
Okay, I have added a version check to both /admin/reports/status and /admin/reports/redis.
From what I can see, ACL's are supported by:
- PhpRedis 5.3.0+
- Predis 1.1.4+
As far as I can tell ACLv2 brings server-specific enhancements (mainly selectors and key-based permissions), but does not introduce incompatibilities with regards to how the client connects to the server. In short this patch brings support to both ACLv1 and ACLv2.
Okay! Feel free to transfer ownership. Thanks!
Thanks!
I tested both patches (against 5.x and 6.x) and they both worked.
I have added automated tests. Note that the full suite of tests is unlikely to pass as 1.0.x-dev already shows 6 failures without this patch:
Here is a proposed patch.
Fixed indentation.
I ran into this as well and ran this script to set the missing labels:
$bundles = \Drupal::service('entity_type.bundle.info')->getBundleInfo('site_setting_entity');
foreach ($bundles as $bundle_machine_name => $bundle_value) {
$this->database->update('site_setting_entity_field_data')
->fields(['name' => $bundle_value['label']])
->condition('type', $bundle_machine_name)
->isNull('name')
->execute();
}
Failpatch failed as expected -- now here is the full patch, let's see if it succeeds...
Thanks for the review @quietone -- I reached out to #migration in slack and came up with a failpatch that includes a migration test. Moving to NR to check if it fails...
Updated patch to accommodate automated tests.
Somehow the bot says a test about conditional access is failing. The changeset added in #10 only addresses a messenger deprecation so it is not clear how this is related.
Here is an attempt to resolve this, let's see what the bot says...
Patch #2 works fine on our side. Thanks!
There is one limitation though: the form shows no success or error message when submitted.
This is because the patch is using drupal_set_message() which is now deprecated
https://www.drupal.org/node/2774931 →
Attached is a new patch that replaces drupal_set_message() with \Drupal\Core\Messenger\MessengerInterface::addMessage() as recommended by the change record above.
Thanks for reviewing! Here is a re-roll against 2.0.x...
Here is a proposed patch.
+1 that would be handy !
Thanks !
Thanks for the quick reply !
Here is a proposed patch that works for us.