Migrate block content-type visibility settings

Open on Drupal.org →

Created on 15 June 2023, almost 2 years ago

Problem/Motivation

The block migration does not seem to support migrating content type visibility settings:

Any chance this can be supported?

Steps to reproduce

On a Drupal 7 site, configure a block to show up only on specific content types (see screenshot above)
Migrate the site to Drupal 10 by executing d7_block.yml

Expected result: the block is still configured to show up on specific content types in Drupal 10

Actual result: the visibility criteria are not migrated

Proposed resolution

Attached is a proposed patch that adds support for this.

✨ Feature request

Status

Needs review

Version

10.1 ✨

Component

Last updated about 14 hours ago

Maintained by
🇺🇸United States @benjifisher
@heddn
🇺🇸United States @mikelutz
🇳🇿New Zealand @quietone

Created by

🇨🇦Canada fengtan Montreal, Canada

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,417 pass, 12 fail
Issue created by @fengtan
Comment almost 2 years ago →
System Message
The last submitted patch, migrate-block-node-type-visibility.patch, failed testing. View results →
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,430 pass
Comment almost 2 years ago →
🇨🇦Canada fengtan Montreal, Canada
Updated patch to accommodate automated tests.
Status changed to RTBC almost 2 years ago5:21pm 17 June 2023
Comment almost 2 years ago →
🇺🇸United States smustgrave
Seems like a valid simple request.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,430 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,430 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,436 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,436 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
29,436 pass
Status changed to Needs work almost 2 years ago1:05am 28 June 2023
Comment almost 2 years ago →
🇳🇿New Zealand quietone
If this data existing on D7 and is not migrated then it is a task, changing status.

Looking at the comments I see no evidence of a review of this change. Setting back to NR.

However, I looked at the patch. A migration also needs a Kernel migration test and a fail patch. Setting back to NW. Ask in #migration for support on those.
Status changed to Needs review almost 2 years ago3:10pm 18 July 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update almost 2 years ago
29,446 pass, 1 fail
Comment almost 2 years ago →
🇨🇦Canada fengtan Montreal, Canada
Thanks for the review @quietone -- I reached out to #migration in slack and came up with a failpatch that includes a migration test. Moving to NR to check if it fails...
Comment almost 2 years ago →
System Message
The last submitted patch, 6: migrate-block-node-type-visibility-3367125-6-failpatch.patch, failed testing. View results →
Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update almost 2 years ago
Waiting for branch to pass
Comment almost 2 years ago →
🇨🇦Canada fengtan Montreal, Canada
Failpatch failed as expected -- now here is the full patch, let's see if it succeeds...
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update almost 2 years ago
29,819 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update almost 2 years ago
29,822 pass, 1 fail
Status changed to Needs work almost 2 years ago2:25pm 19 July 2023
Comment almost 2 years ago →
🇺🇸United States smustgrave
Seems to be failing on the 11.x branch.
Comment 11 months ago →
🇳🇿New Zealand quietone
Status changed to Postponed 14 days ago11:57am 23 May 2025
Comment 14 days ago →
🇳🇿New Zealand quietone
The Migrate Drupal Module was approved for removal in 📌 [Policy] Migrate Drupal and Migrate Drupal UI after Drupal 7 EOL Fixed .

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project → and the Extensions approved for removal → policies.

The deprecation work is in 📌 [12.x] [Meta] Tasks to remove Migrate Drupal module Postponed and the removal work in 📌 [12.x] [Meta] Tasks to remove Migrate Drupal module Postponed .

Migrate Drupal will not be moved to a contributed project. It will be removed from core after the Drupal 12.x branch is open.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024