- Issue created by @HeikkiY
- 🇫🇷France judapriest Grenoble
Font awesome has also incorporated the X logo : https://fontawesome.com/search?q=twitter&o=r
I've replaced the name of the Platform plugin to X, added a description, icon name (used to add a class that is then used by fontawesome).
I've updated the version of the external fontawesome library.So I didn't change the class name nor the url as they are still using the twitter.com url.
- Status changed to Needs review
10 months ago 7:21am 8 September 2023 - 🇮🇳India djsagar
Hi all,
Patch #3 working as expected, verified changes and shared attachment for reference.
RTBC +1.
Regards!
- First commit to issue fork.
- 🇨🇦Canada fengtan Montreal, Canada
#3 works fine -- thanks!
With regards to setting the
urlPrefix
to https://x.com instead of https://www.twitter.com/ -- I believe this would prevent users from re-saving existing URLs (they would have to update the links from x.com to twitter.com upon saving the form), which may be annoying.Also x.com currently redirects to twitter.com so people may have a hard time generating URLs with x.com.
An alternative is to create a new, distinct social network
X
on top ofTwitter
so end users would be able to choose whether they want their link to be rendered with the bird icon or with an X. The domain constraint would match the network they pick. - 🇧🇷Brazil carolpettirossi Campinas - SP
I applied patch #7 and it works as expected.
- Status changed to RTBC
8 months ago 7:46pm 1 November 2023 - 🇺🇸United States tawiiams
Any idea when this will be added to a stable release?
-
Neslee Canil Pinto →
committed 67c6ff5c on 8.x-2.x
Issue #3384469 by chishiki, Lus, MichaelLHenson: Replace Twitter with X
-
Neslee Canil Pinto →
committed 67c6ff5c on 8.x-2.x
- Status changed to Fixed
3 months ago 1:57pm 14 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- 🇺🇸United States rraney
How is a patch considered "fixed"? Is that common in module maintenance?
- 🇺🇸United States platinum1
The patch indeed works, but "X" does not have a "www" in the URL.
Not correcting this results in a 301 error on every page that the block is used.