- last update
over 1 year ago 625 pass, 2 fail - π¨π¦Canada fengtan Montreal, Canada
Patch #2 works fine on our side. Thanks!
There is one limitation though: the form shows no success or error message when submitted.
This is because the patch is using
drupal_set_message()
which is now deprecated https://www.drupal.org/node/2774931 βAttached is a new patch that replaces drupal_set_message() with \Drupal\Core\Messenger\MessengerInterface::addMessage() as recommended by the change record above.
The last submitted patch, 10: purge-2853613-10.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
over 1 year ago 625 pass, 2 fail - Status changed to Needs review
over 1 year ago 3:55pm 2 June 2023 - last update
over 1 year ago 635 pass - π¨π¦Canada fengtan Montreal, Canada
Somehow the bot says a test about conditional access is failing. The changeset added in #10 only addresses a messenger deprecation so it is not clear how this is related.
Here is an attempt to resolve this, let's see what the bot says...
- last update
about 1 year ago 610 pass - π¨π¦Canada fengtan Montreal, Canada
Patch does not apply anymore against 8.x-3.x -- re-rolled
- ππΊHungary junkuncz
purge-2853613-12.patch
patch works well and the code looks very solid however unfortunately I had no time to do a detailed review/report but definitely a good candidate to merge. - Status changed to RTBC
10 months ago 2:45pm 28 January 2024 - π©πͺGermany marvin_B8
I have tried the patch purge-2853613-12.patch and it works as expected. I can provide screenshots if this is wanted .
- First commit to issue fork.