Variable::export should export use short-hand array syntax

Attached patch against drupal 10.1.x

Reviewed #25 with drupal:10.1.x, the patch applied successfully attaching screenshot for reference. it replaced all array() with [ ]. RTBC +1

#15 still needs to happen.

patch #25 is adding an additional change from the reroll

-   *   A prefix that will be added at the beginning of every lines of the output.
+   *   A prefix that will be added at the beginning of
+   *   every lines of the output.
    *

Failure is a legitimate one.

@TanujJain-TJ thank you for looking but you don't need to provide a screenshot of the patch applying as that's shown by the CI build

Adding tag.

Still needs a followup but setting to NR for now.

Don't believe a follow up is needed as the code in question at that time doesn't appear to be changed.

Rest seems pretty straight forward. The added periods surprised haven't been picked up before by a check.

So the problem with only fixing the non var_export() path is that makes this method do both short and long array syntax. We also have a problem that we don't consistently use this method. We probably should be using \Drupal\Component\Utility\Variable::export in \Drupal\Core\Site\SettingsEditor::exportSingleSettingToPhp and other places in core where we use var_export. In an ideal world https://wiki.php.net/rfc/var-export-array-syntax would have landed in PHP. But for now we should be adding a follow-up to the var_export path as requested by #15 because this change leaves this method in an inconsistent state.

Follow up made, 📌 Variable::export uses var_export which does not use short array syntax Active

#35 appears to be addressed. Surprised the pipeline shows red when https://git.drupalcode.org/project/drupal/-/pipelines/292903 is green.

Committed cf8f499 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.