Move \Drupal\field_ui\Form\EntityViewDisplayEditForm::getFieldLabelOptions() to a trait

Plus one for trait and constants, but I think probably do that in two issues, trait first (easier) and constants second (not so easy)

I will take a look on it.

Hi I added a trait please revise.

Nitpicky but if we are going to move can we typehint while at it

Other then that looks good!

LGTM

Nice little clean up! 👍 Posted one comment on the MR

We also need a follow-up if we want to do #13.

Hi @laurii to be honest I didn't understand your comment here

Should we use the trait here since that's why we are moving it to a trait and this issue is mentioned in this comment?

are you being ironic? Should I explain why we are moving the method to trait in this comment, please can you explain again?

Feel free to correct if I'm wrong, but AFAIK we were moving \Drupal\field_ui\Form\EntityViewDisplayEditForm::getFieldLabelOptions to a trait so that we wouldn't have to hard code those values again in

\Drupal\layout_builder\Plugin\Block\FieldBlock::blockForm

. The MR moves the options to a trait but keeps the hard coded values in \Drupal\layout_builder\Plugin\Block\FieldBlock::blockForm, so I proposed that we would do the second step too to get rid of the hard coded values from \Drupal\layout_builder\Plugin\Block\FieldBlock::blockForm.

Hi lauriii, I tryed to aplly the trait, tell me if I did it right?
the next step would be remove the @todo and create the followup?

For open threads in MR.

Despite the test failures think this is close!

For some reason, all of the tests were failing on the main branch on my local enviromment, so I could not test if this change will work. but I think it will :D

I think it's a coincidence if this passes. Field UI module is not required for Layout Builder as of #2935999: Remove Layout Builder's hard dependency on Field UI → .
I think the trait should live in Field module, and we should make sure we have test coverage for this continuing to work when Field UI is not installed

A question, if moved to the Field module, will be available to be used in Field_Ui?
because it is used in Drupal\field_ui\Form\EntityViewDisplayEditForm

The test passed!
I moved the trait to 'core/modules/field/src/GetFieldLabelOptionsTrait.php'

Opened up https://www.drupal.org/project/drupal/issues/3367302 📌 make the allowed values into constants Active for the follow up

Thanks folks!

Left a comment on the MR

Will be good to use this in ✨ Add the notion of a 'configured layout builder block' to solve a number of content-editor and performance pain points Active which is where I came across the todo

Thank you, I updated the name and function based on review.
Please review again?

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I am so sorry, I forgot about consequences of renaming a file!
Thank you bot.
Fixed now.

Changes look good

Issue credits

Fixed on commit.

We shouldn't be referring to where a piece of code came from in documentation, we can use git history for that.

Instead we should be documenting the purpose of the trait.

Felt it wasn't pushing back just for that so changed on commit.

diff --git a/core/modules/field/src/FieldLabelOptionsTrait.php b/core/modules/field/src/FieldLabelOptionsTrait.php
index ba42d528a60..275b08e8ecc 100644
--- a/core/modules/field/src/FieldLabelOptionsTrait.php
+++ b/core/modules/field/src/FieldLabelOptionsTrait.php
@@ -3,7 +3,7 @@
 namespace Drupal\field;
 
 /**
- * Method getFieldLabelOptions originally from EntityViewDisplayEditForm file.
+ * Provides a trait for the valid field label options.
  */
 trait FieldLabelOptionsTrait {

Committed 4aa426d and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.