Correct vertical tab does not focus on form validation

Hi, is there a patch for D9 for horizontal tabs as well?

on 9.5.7 patches not applying. Both vertical and horizontal tabs have this issue. We won't be able to use tabs at this point in time.

re #37 testing should never require installing a contrib module like field_group. Any issue fixed in core should be reproduceable with just core, otherwise its an issue that should be filed with the contrib module. In this case it is a confirmed problem.

To reproduce, you need to have a field inside a vertical tab that can fail validation. Usually, required and similarly validated fields are not inside tabsets in core

The easiest way to reproduce IMO is apply 2911932-30-test-only.patch from #30, which already reproduces the problem for the purposes of testing. Enable theform_test module (must have

$settings['extension_discovery_scan_tests'] = TRUE;

).

Then go to form-test/group-vertical-tabs and enter "bad" into the input in "Second group element", go to an different tab, then submit to trigger an error.
It not working === it does not switch to second tab, where the error is

Problem Happening
https://youtu.be/kYnLIIWCQes

Problem Fixed
https://youtu.be/Ydr06gybiFI

Re #37

on 9.5.7 patches not applying. Both vertical and horizontal tabs have this issue. We won't be able to use tabs at this point in time.

That makes sense as patches are built for the most recent dev branch, which is currently 10.1.x. This can probably be made into a 9.x patch pretty easily - if you have success with that perhaps upload it here for users who may also need it.

Thanks for the clarity @bnjmnm and the youtube links!

Did as you suggested and used the form_test module for testing.
Patch works great!

The last submitted patch, 30: 2911932-30-test-only.patch, failed testing. View results →

The last submitted patch, 30: 2911932-30-test-only.patch, failed testing. View results →

The last submitted patch, 30: 2911932-30-test-only.patch, failed testing. View results →

The last submitted patch, 30: 2911932-30-test-only.patch, failed testing. View results →

The last submitted patch, 30: 2911932-30-test-only.patch, failed testing. View results →

Committed 8f9e0bd and pushed to 10.1.x. Thanks!

Triggered 10.0.x tests for backport.

Cherry-picked to 10.0.x. Still need a separate patch for 9.5.x backport.

I have attached the re-rolled patch for 9.5.x

Reroll seems fine.

The last submitted patch, 49: 2911932-49.patch, failed testing. View results →

Seems random

Committed 5b7e07a and pushed to 9.5.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

I'm using a module that makes the log message field in the 'information' tab of drupal core required ( https://www.drupal.org/project/require_revision_log_message → ) and ran into this issue. Was hoping that this patch would address the issue but it does not seem to. If anyone has the capacity to assist that would be appreciated