Extracts the JS translation string parser from _locale_parse_js_file to a dedicated PHP function

Created on 7 July 2017, almost 8 years ago
Updated 22 March 2023, over 2 years ago

Problem/Motivation

\_locale_parse_js_file restricted the input source to local resources only. It reduced the fixiable to parse user JS from modules, remote files by 3rd parties and unable to pass data:// streams to the function and parsing.

Also, we may parse dynamic JS data and not to interactive with DB updates.

Proposed resolution

- Move the Parser to a dedicated function

Remaining tasks

- Review

User interface changes

API changes

- Add \_locale_parse_js_file()

Data model changes

๐Ÿ“Œ Task
Status

Needs work

Version

10.1 โœจ

Component
Localeย  โ†’

Last updated 4 days ago

Created by

๐Ÿ‡ญ๐Ÿ‡ฐHong Kong droplet

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot โ†’ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide โ†’ to find step-by-step guides for working with issues.

  • First commit to issue fork.
  • @bhanu951 opened merge request.
  • Status changed to Needs review over 2 years ago
  • Status changed to RTBC over 2 years ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    Proposed solution seems to be covered without causing failures.

  • Status changed to Needs work over 2 years ago
  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom catch

    The issue summary looks like it's asking for a new API method to re-use that functionality in contrib, however a new private function doesn't do that. Should this all move to a class with static methods? Or a service?

Production build 0.71.5 2024