Localization update feature logs 404 errors too aggressively

Created on 20 May 2017, over 7 years ago
Updated 18 September 2024, about 2 months ago

Problem/Motivation

Hi, thanks for this amazing module. It's really helpful :-)

On a multi-language site, there are errors popping up in watchdog looking for updated translations which are 404ing.

Example (Korean):
http://ftp.drupal.org/files/translations/8.x/twig_tweak/twig_tweak-8.x-1...

This is the only contrib module I have installed that is getting this error, and the others definitely don't have any translations. So, there's something going on with this module that is actively looking to find non-existent translations for all languages active on the site.

Steps to reproduce

Proposed resolution

TBA See #31

Remaining tasks

Issue Summary update to explain the solution chosen
Respond to #19
Add a test

User interface changes

API changes

Data model changes

Release notes snippet

๐Ÿ› Bug report
Status

Needs work

Version

11.0 ๐Ÿ”ฅ

Component
Localeย  โ†’

Last updated 7 days ago

Created by

๐Ÿ‡น๐Ÿ‡ผTaiwan sgp913

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • ๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand quietone

    I don't understand why this is postponed based on my comment in #31. In that comment I think I outlined the work that needs to be done here next. I am setting back to needs works.

  • heddn Nicaragua

    I like where this is going. But why are we so worried about removing these noisy log messages? I've got a 40+ language website that we have a full install profile test suite setup. For me, the issue is deeper. Because we do a foreach on each module in each language, testing and installing the site from configuration takes a _really_ long time. In addition to logging to drush or watchdog, it would be nice to use async guzzle and call each of the URLs in a shorter time frame. It would speed up downloads. I think we'd need to concern ourselves with some type of poor mans throttle so we don't send off 1000 URL requests, or even 100. That higher volume of traffic might cause performance issues on the localization servers.

  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany Anybody Porta Westfalica

    Sadly this needs another reroll for Drupal 10.2. Doesn't apply anymore.

  • First commit to issue fork.
  • Status changed to Needs review 11 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia sudishth

    Created MR for 11.x

  • Status changed to Needs work 11 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    #31 mentions an issue summary update which is still needed.

    Also test coverage.

  • ๐Ÿ‡ฆ๐Ÿ‡นAustria aurelianzaha

    I would propose a slightly different approach, by marking the file with locale_translation_update_file_history() instead of locale_translation_status_save()

    The patch attached

Production build 0.71.5 2024