file_create_url() causes LogicException when used with certain stream wrappers

// Attempt to return an external URL using the appropriate wrapper. if ($wrapper = \Drupal::service('stream_wrapper_manager')->getViaUri($uri)) { return $wrapper->getExternalUrl(); } else { return FALSE; }

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Seems at some point test coverage was lost so adding back the tests tag.

This could use an issue summary update to show what the proposed solution, remaining tasks, api changes, etc.

New functions should be typehinted for 10

Adding a new interface will require a change record to announce to others.

Thanks.

Comment almost 2 years ago →

🇫🇷France andypost

+++ b/core/lib/Drupal/Core/StreamWrapper/PrivateStream.php
@@ -45,8 +45,25 @@ public function getDirectoryPath() {
+   * @return \Drupal\Core\Url
+   *   A Url representation of the resource.
...
+  protected function getUrl() {
     $path = str_replace('\\', '/', $this->getTarget());
-    return Url::fromRoute('system.private_file_download', ['filepath' => $path], ['absolute' => TRUE, 'path_processing' => FALSE])->toString();
+    return Url::fromRoute('system.private_file_download', ['filepath' => $path], ['absolute' => TRUE, 'path_processing' => FALSE]);

Sounds like exactly this method should be public and its consumers will use it as string and can manage cache metadata

Comment almost 2 years ago →
🇫🇷France andypost
Comment almost 2 years ago →
🇫🇷France andypost