- Status changed to Needs review
almost 2 years ago 2:22am 16 January 2023 - Status changed to Needs work
almost 2 years ago 3:24pm 21 January 2023 - Status changed to Needs review
almost 2 years ago 1:26am 7 February 2023 - πΊπΈUnited States smustgrave
Updated MR based on π Create a redirect for the new Block types path Fixed
- π¦πΊAustralia acbramley
It looks like the last piece of feedback on the MR was around that deprecation message which I've updated to match the other issue that was just committed :) hoping for an RTBC on this now!
- Status changed to Needs work
almost 2 years ago 1:28pm 7 February 2023 The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 1:38pm 7 February 2023 - Status changed to Needs work
almost 2 years ago 3:16am 9 February 2023 - π¦πΊAustralia acbramley
We need feedback on whether the empty arm of the upgrade path needs tests. To me this is slightly overkill but others might disagree.
@mstrelan and I already tested locally with the getOption approach and it failed as per the MR comment.
- Status changed to Needs review
almost 2 years ago 12:22am 21 February 2023 - Status changed to RTBC
almost 2 years ago 1:41am 21 February 2023 - π¦πΊAustralia mstrelan
Setting to RTBC as per my earlier testing β¨ Move Custom block library to Content Fixed and all feedback has now been addressed.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Updating issue credits, crediting those who provided meaningful reviews that changed the course of the patch, those who were involved in usability testing and review and those who made significant issue summary updates
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Did another round of manual testing and another code review, looks good to me.
-
larowlan β
committed d7c4cf1b on 10.1.x
Issue #2862564 by smustgrave, Manuel Garcia, ifrik, acbramley, amjad1233...
-
larowlan β
committed d7c4cf1b on 10.1.x
- Status changed to Fixed
almost 2 years ago 10:19pm 21 February 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
πππ
Committed d7c4cf1 and pushed to 10.1.x. Thanks!
Confirmed the change record already mentions this.
Updated the draft release notes to reference this and the block-types move.
Nice work everyone
See you in π Rename Custom Block terminology in the admin UI Fixed and π Move block content edit and delete routes under admin/content/block to improve IA for editors and fix breadcrumbs Fixed
- π³π±Netherlands ifrik
Wow! Thanks so much to everybody who put work into this and pushed it through!
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 1:06pm 30 March 2023 - π³π±Netherlands legolasbo Middelburg
smustgrave β credited legolasbo β .
- πΊπΈUnited States smustgrave
Closed π Improve workflow for creating custom blocks Closed: duplicate moving over credit. Placing here as I don't have ability to add credit to the META.