Allow the date format to be set from the BEF interface

A warning appeared as below, so I've updated the latest patch to check if the filter is set or not before checking if datepicker is selected.

Warning: Undefined array key "filter" in Drupal\better_exposed_filters\Plugin\views\exposed_form\BetterExposedFilters->exposedFormAlter() (line 797 of modules/contrib/better_exposed_filters/src/Plugin/views/exposed_form/BetterExposedFilters.php).

Please ignore better_exposed_filters_allow_the_date_format-2858610-23_2.patch

Hi, I tried #44, but it didn't work.
I had to use #37, but I also had to add a new date format, as @scuba_fly said in #40.
The new format must be set like "19-05-23" as "19/05/23" won't work.
Remember to clear cache.

Drupal: 9.5.5
BEF: 5.2

Using Drupal Version 9.5.8, better_exposed_filters version 6.0.3, jquery_ui_datepicker 1.4.0 and patch #44 the date filter is working only with the 'd-m-Y' date format.

I started a fresh MR, not based on the previous patches, because I don't really agree with the approach there. Some differences:

• A lot simpler, less code.
• No global module config is added. The date format is stored in the filter widget config instead.
• Every date format is now compatible. Before, only formats that were parseable by the strtotime function were supported.

Let's stop posting patches now in order to prevent duplicate work and potential confusion.

I really like the latest MR, it is super clear. I made some small remarks in the MR.

Thanks @DieterHolvoet!

Merge request 47 worked perfectly for me, except until I needed to use an in-between date filter, which instead provides multi-date fields (min and max).

The exposedFormAlter() Seems to have special cases for the min/max fields already, but the same does not seem to exist for the exposedFormSubmit() and getElement() functions.

I made some changes to make it work on a project of mine. I'm not sure how to fork from @DieterHolvoet's existing branch, so I'm attaching a patch with the changes (Relative to the MR 47). It can be seen as a diff.

If you could review it and include it on your MR it would be greatly appreciated @DieterHolvoet!

I'm not sure how to fork from @DieterHolvoet's existing branch

There should be a button at the top of the page saying Get push access. Afterwards click Show commands and you'll get the Git commands necessary to check out the branch locally.

Thank you @DieterHolvoet, I pushed my changes directly to the branch

Will need a post update hook for the schema change.

Any updates on this?

Still appears to need a post update hook.

The MR seems broken since the changes in 📌 Remove dependency on jquery_ui_datepicker Needs work .
JQuery UI datepicker library seems to be removed since release 6.0.6.
So the MR should be updated, to be able to set the desired date format in another way.

This patch does not apply anymore indeed.
Since 6.0.6 uses the native date element, the localization of date formats already works out of the box (using browser settings), making this feature (controlling the exact format) a bit less necessary for most use-cases.

So question is this needed by anyone anymore with removal of jquery?

I just tried out 7.0.0-beta1. For me personally this issue can be closed, since the browser now automatically uses a localized date format for the date picker.

Thanks everyone that worked on this. Does seem to no longer be needed with removal of jquery.

smustgrave → closed merge request !12

smustgrave → closed merge request !47