Export single simple configuration name has no empty value, resulting in confusing UI

Hello,

I made a new patch and in this case I am correcting both the initial problem of the issue:

• Adding for export single simple configuration name the empty value
• The problem that when we switching back to the '- Select-' state the text area shows 'false' value

I added a gif where you can check that is working (After-patch-2622468-36.gif)
If there's anything I can improve just let me know!

Thanks

I have verified and tested patch #36 on Drupal 9.5 and it working fine.
Both of the issues were addressed.
@Leticia Gauna provide an interdiff file.

Sorry delay @omkar_yewale!

Here is the interdiff file, the patch is in the comment #36 https://www.drupal.org/project/drupal/issues/2622468#comment-15027683 🐛 Export single simple configuration name has no empty value, resulting in confusing UI RTBC

Thanks

Will need a simple assertion to show the bug is fixed please.

Added test, please review

Confirmed applying patch #40 that going to the configuration export page the first option is -Select-

+++ b/core/modules/config/src/Form/ConfigSingleExportForm.php
@@ -154,8 +154,8 @@ public function updateExport($form, FormStateInterface $form_state) {
+    $form['export']['#value'] = !$this->configStorage->read($name) ? NULL : Yaml::encode($this->configStorage->read($name));
+    $form['export']['#description'] = !$this->configStorage->read($name) ? NULL : $this->t('Filename: %name', ['%name' => $name . '.yml']);

we're calling $this->configStorage->read($name) 3 times here now

How about we do something like this instead

$exists = $this->configStorage->exists($name)

And then use that for our logic instead

Other than that, this looks great - thanks!

Hey - Here is the patch with test and larowlan suggestion!

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Removed extra + symbols from previous patch.

Seems point #44 has been addressed.

The last submitted patch, 48: 2622468-48.patch, failed testing. View results →

Seems to be unrelated failure.

Committed 288f761 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.