Comment types UI confusing and inconsistent

Some of the title related feedback will hopefully be resolved by 🐛 Page title should contextualize the local navigation Needs work . I'll make sure to check if that's the case, and if not, I'll open follow-up for this 👍

Here's a patch that does two things I believe will address majority of the remaining feedback. I'm changing the select to a required field, without a default value. This way users have to explicitly select a target entity type. I'm also adding the target entity type to the comment type list since it is fundamental information about comment types.

Oops, the patch contains 🐛 Comment settings are confusing Fixed . Here's one without the unrelated changes.

Could we address the comment type breadcrumb in the patch too? Even testing this I got a little confused what comment type i was on when i was on the manage fields page.

That's touching different part of the code so I opened a follow-up for that 🐛 Comment type form title is confusing Fixed . Will file a patch there in a moment.

Sounds good to me

1. +++ b/core/modules/comment/src/CommentTypeListBuilder.php
   @@ -12,6 +15,28 @@
   +   * Constructs a new EntityListBuilder object.
   

   This is a CommentTypeListBuilder.

2. +++ b/core/modules/comment/src/CommentTypeListBuilder.php
   @@ -12,6 +15,28 @@
   +  public function __construct(EntityTypeInterface $entity_type, protected EntityTypeManagerInterface $entityTypeManager) {
   

   How does this work when the parent constructor is

     public function __construct(EntityTypeInterface $entity_type, EntityStorageInterface $storage) {
   

Not sure what I was thinking when I wrote that 😇 Addressed!

Seems points in #29 have been addressed.

Committed and pushed 023898d3f9 to 11.x (10.2.x). Thanks!

Discussed with @lauriii and we decided not to backport as this is a UI change and may break someone's tests.

Automatically closed - issue fixed for 2 weeks with no activity.