Comment type form title is confusing

Agree the title could be updated.

I checked content types and media types
Content types = Edit Article content type
Media type = Edit Audio

So can we use Edit [comment-type-name] or Edit [comment-type-name] comment type

dhirendra.mishra → made their first commit to this issue’s fork.

dhirendra.mishra → closed merge request !4388

We might be adjusting or getting rid of some of these title overrides in 🐛 Page title should contextualize the local navigation Needs work but agree that it makes sense to be consistent here. 👍

The last submitted patch, 7: 3374626-7.patch, failed testing. View results →

Couple small improvements after a self-review. 😇

Title change looks good.

Edit Default comments comment type

+++ b/core/modules/comment/comment.routing.yml
@@ -135,7 +135,7 @@ entity.comment_type.edit_form:
+    _title_callback: '\Drupal\comment\Controller\CommentTypeController::commentTypeTitle'

I think this can use \Drupal\Core\Entity\Controller\EntityController::title then we don't need a custom controller or method.

Makes sense 👍

LGTM. Surprised this wasn't reported until 2023.

Static review looks good. Actually tested the patch, attached screenshot.

Please ignore #16 , Created by mistake

Committed and pushed 95dcdb3f58 to 11.x. Thanks!

Discussed with @lauriii at Drupal Dev Days and decided not to commit to 10.1.x as there is a new translatable string, it's a UI bug that has existed for a long time and it can wait for 10.2.x.

Automatically closed - issue fixed for 2 weeks with no activity.