- Issue created by @lauriii
- Status changed to Needs review
12 months ago 11:14am 14 July 2023 - last update
12 months ago 29,814 pass - Status changed to Needs work
12 months ago 2:07pm 14 July 2023 - 🇺🇸United States smustgrave
Agree the title could be updated.
I checked content types and media types
Content types = Edit Article content type
Media type = Edit AudioSo can we use Edit [comment-type-name] or Edit [comment-type-name] comment type
- 🇮🇳India dhirendra.mishra
dhirendra.mishra → made their first commit to this issue’s fork.
- Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
12 months ago Not currently mergeable. - @dhirendramishra opened merge request.
- Status changed to Needs review
12 months ago 6:54am 15 July 2023 - last update
12 months ago 29,806 pass, 1 fail - 🇫🇮Finland lauriii Finland
We might be adjusting or getting rid of some of these title overrides in 🐛 Page title should contextualize the local navigation Needs work but agree that it makes sense to be consistent here. 👍
The last submitted patch, 7: 3374626-7.patch, failed testing. View results →
- last update
11 months ago 29,815 pass - last update
11 months ago 29,815 pass - Status changed to RTBC
11 months ago 2:20pm 17 July 2023 - 🇺🇸United States smustgrave
Title change looks good.
Edit Default comments comment type
- 🇬🇧United Kingdom longwave UK
+++ b/core/modules/comment/comment.routing.yml @@ -135,7 +135,7 @@ entity.comment_type.edit_form: + _title_callback: '\Drupal\comment\Controller\CommentTypeController::commentTypeTitle'I think this can use
\Drupal\Core\Entity\Controller\EntityController::titlethen we don't need a custom controller or method. - Status changed to Needs work
11 months ago 9:33am 19 July 2023 - Status changed to Needs review
11 months ago 10:21am 19 July 2023 - last update
11 months ago 29,822 pass - Status changed to RTBC
11 months ago 10:31am 19 July 2023 - 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
LGTM. Surprised this wasn't reported until 2023.
Static review looks good. Actually tested the patch, attached screenshot.
- Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
11 months ago Not currently mergeable. - @dhirendramishra opened merge request.
-
longwave →
committed 95dcdb3f on 11.x
Issue #3374626 by lauriii, penyaskito, smustgrave, longwave: Comment...
-
longwave →
committed 95dcdb3f on 11.x
- Status changed to Fixed
11 months ago 1:38pm 19 July 2023 - 🇬🇧United Kingdom longwave UK
Committed and pushed 95dcdb3f58 to 11.x. Thanks!
Discussed with @lauriii at Drupal Dev Days and decided not to commit to 10.1.x as there is a new translatable string, it's a UI bug that has existed for a long time and it can wait for 10.2.x.
Automatically closed - issue fixed for 2 weeks with no activity.