Comment settings are confusing

The last submitted patch, 2: 3373938-2.patch, failed testing. View results →

Yes, The issue that you mentioned in the description is exist. It's showing the validation message that you need to select one option.
The patch that you provided is working perfectly. I think we can go wit it.

Before patch.

After patch.

I have one question - what happens if an entity has no comments + comments closed before this patch is applied, - won't the selected option be hidden then? We might need to to only hide the option if it doesn't match the current value, or.. something.

Before if you had selected hidden (for example because it's default value), it would not be shown in the UI. There would also be no way to select hidden when you have no comments because of 🤷‍♂️

After the patch, "Closed" will be displayed always when it's the current value (set in #default_value). However, if it's not the currently selected option, it's hidden when there are no comments because it doesn't make sense to have this state in that use case. Why would you display an empty comment section (without a way to comment) instead of hide it if there are no comments?

That makes sense now, so we're fixing the issue I was worried about introducing here.

Also committed the issue this was spun out of.

Rerolled #4 on top of 🐛 [regression] "Comments field is required" when creating content for types with a comment field configured as hidden Fixed .

Committed f680053 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

This change affects migration.

It can cause required comment field on node edit form to display no default value.

Attached example image is node edit form comment field for a migrated node that had comment=1 (Closed).

@drpldrp It would be helpful if you could file a new issue, and link it from here 🙏