Add events for matching entity hooks

Try To Fix The Failed CMF #97 Patch . And Add Interdiff between the #97-101.

Try To Fix The Failed CMF #101 Patch . And Add Interdiff between the #101-102

+++ b/core/tests/Drupal/Tests/Core/Entity/KeyValueStore/KeyValueEntityStorageTest.php
@@ -632,7 +632,9 @@
+/**
+ *
+ */

This could actually use some content. An empty PHPDoc doesn't add much value.

Legitimately curious, was #102 just an automated update without reviewing it? The empty comment is a code smell for a rote contribution.

That is quite possible indeed. I've seen a lot of re-rolls recently which were not good, omitting new files and things like adding comments that don't add any value.

Tried to fix CCF for #102.

Instead of removing the PHPDoc you should have added some content/text in it.

addressed the #107 Comment. upload The patch And Interdiff between.

Fix the Failed CMD Patch of Mine.Remove Failed Patch.

The last submitted patch, , failed testing. View results →

The last submitted patch, 110: 2551893-109.patch, failed testing. View results →

I have a project that uses a significant number of these hooks and it would be much nicer if they could be events instead.

What would also be good is if we could have a base EntityUpdateEvent (for all entity types), and extend that to NodeUpdateEvent (for nodes only), and subscribers on EntityUpdateEvent would also receive NodeUpdateEvent. Unfortunately, Symfony does not support this pattern as far as I can tell: https://github.com/symfony/symfony/pull/32079

I find it more challenging https://git.drupalcode.org/project/hux/-/blob/1.x/src/HuxReplacementHook...

@longwave please elaborate "these hooks" dowsides

@andypost all my code is written as services and so the hooks end up being

/**
 * Implements hook_node_update().
 */
function MODULE_node_update(NodeInterface $node) {
  if (in_array($node->bundle(), ['x', 'y'])) {
    \Drupal::service('MODULE.SERVICE')->method($node);
  }
}

It would be cleaner if I could just inject this service into an event listener.

There is a lot of activity around hooks via PHP attributes issue ( 🌱 [META] Hooks via attributes on service methods (hux style) Active ). I think it's time to make a final decision about which way
we are going to replace the current hooks system.
So far we've got the following options.

1. Events via Symfony Event Dispatcher
2. Hooks via PHP attributes
3. Nothing (keep the current hook implementation)

This is required to allow starting work on concrete implementation of the new event/hook system. I am not sure on what is the best way to get the resolution. Guess it needs to be done by framework managers.

Forget !4340...

I moved the changes of !210 to 11.x in !4423
I will start working on the review of @claudiucristea, unless someone beats me to it, or the issue ends up getting dropped.
Having said that.. has there been any discussion on the matter?

Marios Anagnostopoulos → changed the visibility of the branch 2551893-add-entity-events to hidden.

Attaching a patch for 10.2.2 (Based on !4423) (Probably applies to older versions as well, that #97 does not cover)

This needs to be an MR against 11.x at this point.