Lock down StringInterface::setStorage()

Created on 1 March 2015, about 10 years ago

Updated 3 March 2023, about 2 years ago

Before the interface becomes frozen, we are missing an obvious type hinting check.

- public function setStorage($storage);
+ public function setStorage(StringStorageInterface $storage);

📌 Task

Status

Needs work

Version

10.1 ✨

Component

Locale →

Last updated 4 days ago

Created by

🇬🇧United Kingdom martin107

Live updates comments and jobs are added and updated live.

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Needs issue summary update
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 2 years ago →
🇮🇳India prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
Add The Re-roll For The 10.1x Branch.
Comment about 2 years ago →
🇮🇳India TanujJain-TJ
Tried to fix CCF on #27
Status changed to Needs review about 2 years ago1:32pm 3 March 2023
Comment about 2 years ago →
🇮🇳India TanujJain-TJ
Status changed to Needs work about 2 years ago3:56pm 3 March 2023
Comment about 2 years ago →
🇺🇸United States smustgrave
This will need an issue summary update after so long. Simple test case should be used too for coverage.
First commit to issue fork.
@rpayanm opened merge request.

Production build 0.71.5 2024