- πΊπΈUnited States tim.plunkett Philadelphia
@Kobe Wright can you edit the MR to point to 10.1.x?
- @kobe-wright opened merge request.
- π§πͺBelgium Kobe Wright
@tim.plunkett Sure! Created a new MR for 10.1.x
- First commit to issue fork.
- Status changed to Needs review
almost 2 years ago 12:17am 25 February 2023 - Status changed to Needs work
almost 2 years ago 4:33pm 27 February 2023 - πΊπΈUnited States smustgrave
Even though this is a task seems like a feature request.
This will need test coverage of some kind. Probably simple kernel test?
Will need a change record to announce new function.
Left some NIT comments in MR 3451
- Status changed to Needs review
almost 2 years ago 10:43pm 8 March 2023 - Status changed to Needs work
almost 2 years ago 2:24pm 9 March 2023 - πΊπΈUnited States smustgrave
Will need tests also. Not sure if subsystem maintainer has any thoughts.
- @sleitner opened merge request.
- Status changed to Needs review
almost 2 years ago 12:31am 12 March 2023 - Status changed to Needs work
almost 2 years ago 8:35pm 16 March 2023 - Merge request !5509Issue #2410579 by sleitner, Kobe Wright: Allow to change the current language β (Open) created by sleitner
- Status changed to Needs review
about 1 year ago 10:00pm 22 November 2023 - π©πͺGermany sleitner
Rerolled to 11.x and added language reset. Please review.
- ππΊHungary GΓ‘bor Hojtsy Hungary
I don't have explicitly proof but I have feelings about this probably causing some problem with caching. I think for cache contexts related to the already negotiated language, it would cache the strings / render outputs generated from the strings in the wrong language. Would be great to have someone with deep experience of the cache system consider this. In other words I think this is meant to be negotiated and used from then on, and not changed.
The language manager has the ability to set a configuration override language. That works for example for user_mail(), where we just need to load configuration in the language of the user.
However, more advanced cases need to be able to change the current language completely. For example Simplenews, where we are building newsletter issues, that includes viewing entities, t() calls in e.g. templates, views queries that use the language context.. all kinds of things.
What makes it not possible to send along the language explicitly to those operations like "user_mail()" does?
- Status changed to Needs work
about 1 year ago 2:10pm 12 December 2023 - πΊπΈUnited States smustgrave
Thanks @GΓ‘bor Hojtsy with sign off think we could use the CR now