I believe Willempje2 is right, updated the MR to correct the condition in the isClonable() function.
Also attaching a patch here.
Kobe Wright → made their first commit to this issue’s fork.
As per my earlier comment #13 I want to reiterate that I explicitly added the language manager again after realising that other plugins (like the one from openid_connect_windows_aad, see https://git.drupalcode.org/project/openid_connect_windows_aad/-/blob/2.0...) still use it, I see that the latest patches are removing it again.
While I myself prefer to clean up unnecessary dependencies as well, we do have to consider the impact for other modules / users.
Not saying we shouldn't delete it but just wondering if it's worth removing it here/now knowing that this will require patching downstream.
What do you guys think?
Thanks @jiong_ye, tested and seems to work fine.
Adding a patch to use with composer based on the merge request (credit to @jiong_ye).
Opened a merge request with the required changes, also adding a patch to use with composer.
Kobe Wright → created an issue.
I was too trigger happy with removing the language manager, other modules might depend on it (as I discovered with openid_connect_windows_aad).
Adding a new patch that keeps it.
Adding a patch to use against 3.0.0-alpha2
Kobe Wright → made their first commit to this issue’s fork.
Opened a merge request with the required changes, also adding a patch to use with composer.
Kobe Wright → created an issue.
- Updated the version to 3.x since this was never merged into 2.x and 3.x is probably the way forward
- Took a stab at a solution that allows you to set minItems and maxItems based on the breakpoints provided by the default theme
- Opened a MR
- Also attaching patch for composer
Also adding the patch for composer
Created a merge request with the required changes.
Kobe Wright → created an issue.
@tim.plunkett Sure! Created a new MR for 10.1.x