- Issue created by @daneduijnkerke
- Status changed to Needs review
about 1 year ago 1:21pm 27 October 2023 - last update
about 1 year ago 25 pass, 7 fail The last submitted patch, 2: 3397218_2.patch, failed testing. View results โ
- Status changed to Needs work
7 months ago 9:13am 27 May 2024 - ๐ณ๐ฑNetherlands willempje2
Your if statement seems to be inverted.
Seems more sensible to skip if cloneable entities are empty or if target entity is not present in the array. - First commit to issue fork.
- Merge request !80Fix clone form is not respecting 'cloneable_entities' config. โ (Open) created by rajeshreeputra
- ๐ฎ๐ณIndia rajeshreeputra Pune
Let's wait for pipeline to run, once green will merge and release.
- Status changed to Needs review
5 months ago 12:35pm 17 July 2024 - ๐ณ๐ฑNetherlands willempje2
In its current form this will return false if the target_type is in the cloneable_entities config. This is the opposite of what you would want in a isClonable function.
- ๐ง๐ชBelgium Kobe Wright
Kobe Wright โ made their first commit to this issueโs fork.
- ๐ง๐ชBelgium Kobe Wright
I believe Willempje2 is right, updated the MR to correct the condition in the isClonable() function.
Also attaching a patch here.