The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Assigned to akshaydalvi212
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:08am 14 March 2023 - Assigned to akshaydalvi212
- Status changed to Needs work
over 1 year ago 12:43pm 14 March 2023 - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 4:36am 21 March 2023 - Status changed to Needs work
over 1 year ago 3:45pm 21 March 2023 - 🇺🇸United States smustgrave
Okay the file sizes go from
307
36
112
151
106With no explanation why. What happened to the bulk of the changes in #40? Were they already completed? Module removed? This should be documented.
Am removing credit for bad rerolls as it's expected to check your code before uploading. You can check for build errors make sure to run
./core/scripts/dev/commit-code-check.sh
before uploading a patch to make sure there are no issues with code formatting. see https://www.drupal.org/docs/develop/development-tools/running-core-devel... →Starting March 2023, simple rerolls, rebases, or merges will no longer receive issue credit. Only rerolls that address a merge conflict will be credited, and the merge conflict that was resolved must be documented in the text of an issue comment.
Example
error: patch failed: core/modules/system/tests/modules/twig_theme_test/twig_theme_test.module:77
error: core/modules/system/tests/modules/twig_theme_test/twig_theme_test.module: patch does not applyTo receive credit for contributing to this issue, assist with other outstanding tasks or unaddressed feedback.
See the issue credit guidelines → for more information. - 🇺🇸United States smustgrave
Tagging for issue summary for the open questions
- Assigned to quietone
- Status changed to Postponed
over 1 year ago 7:59am 22 March 2023 - 🇳🇿New Zealand quietone
This is a coding standards issue, tagging as such. Coding standard
In order to fix core coding standards in a maintainable way, all our coding standards issues are done on a per-rule basis across all of core, rather than fixing standards in individual modules or files. If you are interested in working on coding standards issues, go to 📌 [Meta] Fix coding standards in core Active and select an existing issue.
@akshaydalvi212, @adeshsharma and @Aadhar_Gupta, Thanks for the interest in improving Drupal coding standards! I have looked at the patches and as we can see from the test results, there are multiple errors. For the failing the pre commit checks see Run core development checks → locally before submitting a change. This will avoid noise on the issue and allow us to focus on what is being fixed. I also recommend reading the Drupal Contributor Guide as recommended in #46.
Assigning to myself.
- 🇳🇿New Zealand quietone
This is a coding standard fix and they are now done by sniff, not file. See 🌱 [meta] Fix Drupal.NamingConventions.ValidVariableName.LowerCamelName Active
- Issue was unassigned.