In Class ViewExecutable Rename Views properties to core standards

Created on 6 September 2013, almost 11 years ago
Updated 23 March 2023, over 1 year ago

Part of meta-issue 📌 [META] Rename Views properties to core standards Closed: duplicate

Properties to be changed:

- public $build_info
- public $current_page
- public $items_per_page
- public $total_rows
- public $attachment_before
- public $attachment_after
- public $exposed_data
- public $exposed_input
- public $exposed_raw_input
- public $old_view
- public $parent_views
- public $is_attachment
- public $current_display
- public $display_handler
- public $style_plugin
- public $row_index
- public $override_url
- public $override_path
- public $base_database
- public $exposed_widgets
- public $get_total_rows
- public $build_sort
- public $many_to_one_tables
- public $dom_id

Also, any other file that uses the properties of this class need to be updated, and merged into this issue.

Remaining Tasks

Answer #53

📌 Task
Status

Postponed

Version

10.1

Component
Other 

Last updated 1 minute ago

Created by

🇻🇳Vietnam mrsinguyen

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

  • VDC

    Related to the Views in Drupal Core initiative.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

  • Assigned to akshaydalvi212
  • 🇮🇳India akshaydalvi212

    hey,
    I will work on this issue.

  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India akshaydalvi212

    Patch created for 10.1.x.
    Kindly review.

  • Assigned to akshaydalvi212
  • Status changed to Needs work over 1 year ago
  • Issue was unassigned.
  • 🇮🇳India akshaydalvi212

    Fixed the issues.
    Kindly review

  • Status changed to Needs review over 1 year ago
  • 🇮🇳India Aadhar_Gupta

    Trying to fix all the errors coming in patch on #50

  • Status changed to Needs work over 1 year ago
  • 🇺🇸United States smustgrave

    Okay the file sizes go from

    307
    36
    112
    151
    106

    With no explanation why. What happened to the bulk of the changes in #40? Were they already completed? Module removed? This should be documented.

    Am removing credit for bad rerolls as it's expected to check your code before uploading. You can check for build errors make sure to run ./core/scripts/dev/commit-code-check.sh before uploading a patch to make sure there are no issues with code formatting. see https://www.drupal.org/docs/develop/development-tools/running-core-devel...

    Starting March 2023, simple rerolls, rebases, or merges will no longer receive issue credit. Only rerolls that address a merge conflict will be credited, and the merge conflict that was resolved must be documented in the text of an issue comment.

    Example
    error: patch failed: core/modules/system/tests/modules/twig_theme_test/twig_theme_test.module:77
    error: core/modules/system/tests/modules/twig_theme_test/twig_theme_test.module: patch does not apply

    To receive credit for contributing to this issue, assist with other outstanding tasks or unaddressed feedback.
    See the issue credit guidelines for more information.

  • 🇺🇸United States smustgrave

    Tagging for issue summary for the open questions

  • Assigned to quietone
  • Status changed to Postponed over 1 year ago
  • 🇳🇿New Zealand quietone New Zealand

    This is a coding standards issue, tagging as such. Coding standard

    In order to fix core coding standards in a maintainable way, all our coding standards issues are done on a per-rule basis across all of core, rather than fixing standards in individual modules or files. If you are interested in working on coding standards issues, go to 📌 [Meta] Fix coding standards in core Active and select an existing issue.

    @akshaydalvi212, @adeshsharma and @Aadhar_Gupta, Thanks for the interest in improving Drupal coding standards! I have looked at the patches and as we can see from the test results, there are multiple errors. For the failing the pre commit checks see Run core development checks locally before submitting a change. This will avoid noise on the issue and allow us to focus on what is being fixed. I also recommend reading the Drupal Contributor Guide as recommended in #46.

    Assigning to myself.

  • 🇳🇿New Zealand quietone New Zealand

    This is a coding standard fix and they are now done by sniff, not file. See 🌱 [meta] Fix Drupal.NamingConventions.ValidVariableName.LowerCamelName Active

Production build 0.69.0 2024