Contrib.social

Exposed sorts break custom style plugin sorting

Open on Drupal.org →
Created on 7 June 2013, almost 12 years ago
Updated 25 January 2023, about 2 years ago

Reported for D7 Views here: #1333932: Sorting in table doesn't work when sort criteria is exposed →

The only core implementation of custom style plugin sorting is Table's clicksort. If you expose any sort handlers, clicksort stops working.

Here's the fix, this needs tests.

This will need a reroll when #2002388: Rename Views method build_sort() to buildSort() → goes in.

🐛 Bug report
Status

Needs work

Version

9.5

Component
Views  →

Last updated about 9 hours ago

Created by

🇺🇸United States tim.plunkett Philadelphia

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • VDC

    Related to the Views in Drupal Core initiative.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 years ago →
    🇺🇸United States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

    This is still true in D10
    Was already tagged for tests which will still need to happen.
    Tagging for IS update for proposed solution to be stated and remaining tasks.

  • Comment about 2 years ago →
    🇮🇳India _utsavsharma

    Patch for 10.1.x.

  • Comment 6 months ago →
    🇳🇿New Zealand quietone

    This was a bugsmash random issue today. I added the standard template, hid files, and updated the issue summary with the work to do.

  • First commit to issue fork.
  • Merge request !10057apply patch #20 → (Open) created by oily
  • Pipeline finished with Success
    5 months ago
    Total: 1009s
    #329579
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024