UAE
Account created on 17 May 2010, almost 15 years ago
#

Merge Requests

Recent comments

🇧🇾Belarus spleshka UAE

Looks great, thanks Elaman for resolving this issue. Well done 👏

🇧🇾Belarus spleshka UAE

Hi @sunilpathak, looks like you're running on Drupal 9, which is not supported by the Anu LMS module anymore, as well as it is not supported by the community. The minimal supported Drupal version starting from 1st Nov, 2023 is Drupal 10. I'm closing this issue, because the module works as intended.

🇧🇾Belarus spleshka UAE

We had the same issue with WebP module and Stage File Proxy. After rolling back to 3.1.0 the issue is gone.

🇧🇾Belarus spleshka UAE

Hi @leeksoup - I've asked my colleague (Elaman) who has got experience with Anu LMS customisations to get back to you soon & help with the documentation for cases like yours. He should get back to you soon.

🇧🇾Belarus spleshka UAE

Made the description for Anu LMS recipe more clear for people who haven't heard of it before.

🇧🇾Belarus spleshka UAE

Hey @nojj, you're absolutely right. There was a typo in the MR.

It should have been "drupal/inline_entity_form": "^1.0@RC||^3.0@RC" instead of "drupal/inline_entity_form": "^1.0@RC||3.0@RC" (missing ^).

I've pushed the fix to 2.x and now making a new release. Thank you for reporting the issue!

🇧🇾Belarus spleshka UAE

Thanks @elaman, merged the MR. Let's solve CI / tests issue separately.

🇧🇾Belarus spleshka UAE

Thanks @elaman. Can you please remove changes from PR in this issue not related to the issue as well? It'd help me to merge the changes. Thanks!

🇧🇾Belarus spleshka UAE

@elaman, can you please move CI fixes to another issue, so that we can merge only IEF fix in this issue? I'm worried that otherwise it may take longer to get this in.

🇧🇾Belarus spleshka UAE

Thanks for fixing this @elaman! Let's get this in.

🇧🇾Belarus spleshka UAE

spleshka made their first commit to this issue’s fork.

🇧🇾Belarus spleshka UAE

Looks like it was fixed a while ago.

🇧🇾Belarus spleshka UAE

Hi @sarwan_verma, appreciate the input! I was a little quicker and already merged PR before you provided a patch, but thanks for your contribution anyway!

🇧🇾Belarus spleshka UAE

Spleshka changed the visibility of the branch 3414009-php-8.2-deprecated to active.

🇧🇾Belarus spleshka UAE

Spleshka changed the visibility of the branch 3414009-php-8.2-deprecated to hidden.

🇧🇾Belarus spleshka UAE

Updating issue status to the correct one :)

🇧🇾Belarus spleshka UAE

Great stuff, thank you Leo for providing a patch! I've added small code formatting changes & added changelog record. I will also create a new release to make this fix go live.

🇧🇾Belarus spleshka UAE

Thanks @dastan56 for your work on this. Changing status to RTBC on your behalf based on the comment above.

🇧🇾Belarus spleshka UAE

Thanks @dastan56 for submitting the patch, our team will review it soon.

🇧🇾Belarus spleshka UAE

Can you create a separate ticket for the new issue? Many thanks.

🇧🇾Belarus spleshka UAE

Thanks for reporting the issue. I've made a MR with the proposed fix, can you apply it via your composer.json and let me know if the issue is gone? You can include the patch by the direct reference to the MR like this: https://git.drupalcode.org/project/anu_lms/-/merge_requests/46.diff

🇧🇾Belarus spleshka UAE

Spleshka made their first commit to this issue’s fork.

🇧🇾Belarus spleshka UAE

Hi @chetan 11, thanks for your patch. I looked into the code of the patch and the code is not related to Anu LMS module at all. Can you check it please?

🇧🇾Belarus spleshka UAE

Now it's looking great, thanks Elaman! Happy to get it merged.

🇧🇾Belarus spleshka UAE

Hi @elaman, thanks for creating an issue. I had a look at the code, here are my thoughts:
- CHANGELOG and README updates are needed to reflect the new feature
- I think the name cookie dummy_email must be improved. It should definitely start with "domino_" to indicate that the cookie is related to the Domino module
- The feature as is poses a security vulnerability. When the module with this feature is enabled on the production site (which is the intention, as I far as I can understand), you can literally start hijacking emails sent by Drupal which were not intended to be sent to your email address. It's very dangerous behavior. You need to think of better way to protect this feature for your use case.

🇧🇾Belarus spleshka UAE

Thank you so much @intrafusion for such quick action! Would you be so kind to create a new release for the version supporting Drupal 10 please?

🇧🇾Belarus spleshka UAE

Thanks Elaman, great job. Tested on our website, works well.

🇧🇾Belarus spleshka UAE

Thanks @iamdroid, this should have been fixed a while ago, finally we got to it :)

🇧🇾Belarus spleshka UAE

This is a fair statement. From one hand, React is being the module's advantage as it gives much better UX than what Drupal can offer by default, but it requires React knowledge when it comes down to extending available body blocks. We have plans to simplify paragraphs creation, and there are even ways to render twig templates in react using special babel transpilers, but it's not at the top of our roadmap, unfortunately. If you need any help with templates and looking to have a bit of fun getting a new tool (react) under your belt - we'd be happy to give you a guidance in the Slack channel.

🇧🇾Belarus spleshka UAE

Hi Josip, thanks for using Anu LMS! Answering your question - at the moment there is no such thing as successful or unsuccessful pass of the final quiz. Anu LMS logs the correct / not correct answers. In your custom module you can hook into the quiz submission and based on the amount of success % made further actions in the system. Does it answer your question? Let us know if any help is needed, would be happy to assist.

🇧🇾Belarus spleshka UAE

Hi, in terms of workaround - well, technically the module doesn't have any smart or complex logic. If you just install the Group module and configure it to have organisations and organisation admins then you'll have almost the same functionality that anu_lms_permission has :-)

🇧🇾Belarus spleshka UAE

Done - made an official release supporting Drupal 10 🥳

🇧🇾Belarus spleshka UAE

Hi @rickyhe0706, thanks for reporting the issue. Can you describe your set up / steps to reproduce? Many thanks in advance.

🇧🇾Belarus spleshka UAE

@beloglazov91 thanks. Do we know why a paragraph might be null?

🇧🇾Belarus spleshka UAE

Tested on latest D9 / Anu LMS and could not reproduce the issue. Feel free to re-open if someone will be able to reproduce.

🇧🇾Belarus spleshka UAE

Merged examples into the main branch. Added documentation to https://www.drupal.org/docs/contributed-modules/anu-lms/customising-anu-lms . Happy to mark the issue as fixed!

🇧🇾Belarus spleshka UAE

Changed weight.

🇧🇾Belarus spleshka UAE

Updated links to the example modules.

🇧🇾Belarus spleshka UAE

Added relation to the root Anu LMS page.

🇧🇾Belarus spleshka UAE

Bumped compatible Drupal core version.

🇧🇾Belarus spleshka UAE

Slight content change - adding header and removed repeating "Anu LMS" words.

🇧🇾Belarus spleshka UAE

Added initial content.

🇧🇾Belarus spleshka UAE

Hi @ledjerdemain, we've finally had some time to add an example of how to add a custom paragraph type to Anu LMS: https://git.drupalcode.org/issue/anu_lms-3331125/-/tree/3331125-cant-add.... Hopefully you'll find it helpful :-)

🇧🇾Belarus spleshka UAE

I've created a MR with an example of how to override the existing component (addressing #8). An example of how to add a new custom paragraph is yet to be added to the same MR.

🇧🇾Belarus spleshka UAE

Hey, I'm sorry it's taking so long to update the documentation. It's still on our TODO list.

🇧🇾Belarus spleshka UAE

Nice work, thanks Alexey

🇧🇾Belarus spleshka UAE

Change branch to 7.x, since patch in #174 is for 7.x and needs to be tested by a testbot.

🇧🇾Belarus spleshka UAE

I've also tested patch in #174 and confirm that is works like a charm! Thank you.

Production build 0.71.5 2024