UAE
Account created on 17 May 2010, about 14 years ago
#

Merge Requests

Recent comments

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Looks like it was fixed a while ago.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Hi @sarwan_verma, appreciate the input! I was a little quicker and already merged PR before you provided a patch, but thanks for your contribution anyway!

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Spleshka β†’ changed the visibility of the branch 3414009-php-8.2-deprecated to active.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Spleshka β†’ changed the visibility of the branch 3414009-php-8.2-deprecated to hidden.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Updating issue status to the correct one :)

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Great stuff, thank you Leo for providing a patch! I've added small code formatting changes & added changelog record. I will also create a new release to make this fix go live.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Thanks @dastan56 for your work on this. Changing status to RTBC on your behalf based on the comment above.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Thanks @dastan56 for submitting the patch, our team will review it soon.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Can you create a separate ticket for the new issue? Many thanks.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Thanks for reporting the issue. I've made a MR with the proposed fix, can you apply it via your composer.json and let me know if the issue is gone? You can include the patch by the direct reference to the MR like this: https://git.drupalcode.org/project/anu_lms/-/merge_requests/46.diff

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Spleshka β†’ made their first commit to this issue’s fork.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Hi @chetan 11, thanks for your patch. I looked into the code of the patch and the code is not related to Anu LMS module at all. Can you check it please?

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Now it's looking great, thanks Elaman! Happy to get it merged.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Hi @elaman, thanks for creating an issue. I had a look at the code, here are my thoughts:
- CHANGELOG and README updates are needed to reflect the new feature
- I think the name cookie dummy_email must be improved. It should definitely start with "domino_" to indicate that the cookie is related to the Domino module
- The feature as is poses a security vulnerability. When the module with this feature is enabled on the production site (which is the intention, as I far as I can understand), you can literally start hijacking emails sent by Drupal which were not intended to be sent to your email address. It's very dangerous behavior. You need to think of better way to protect this feature for your use case.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Thank you so much @intrafusion for such quick action! Would you be so kind to create a new release for the version supporting Drupal 10 please?

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Thanks Elaman, great job. Tested on our website, works well.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Closing as a duplicate of πŸ“Œ Drupal 10 compatibility fixes Fixed

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Thanks @iamdroid, this should have been fixed a while ago, finally we got to it :)

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

This is a fair statement. From one hand, React is being the module's advantage as it gives much better UX than what Drupal can offer by default, but it requires React knowledge when it comes down to extending available body blocks. We have plans to simplify paragraphs creation, and there are even ways to render twig templates in react using special babel transpilers, but it's not at the top of our roadmap, unfortunately. If you need any help with templates and looking to have a bit of fun getting a new tool (react) under your belt - we'd be happy to give you a guidance in the Slack channel.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

It has been fixed a while ago, closing the issue.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Hi Josip, thanks for using Anu LMS! Answering your question - at the moment there is no such thing as successful or unsuccessful pass of the final quiz. Anu LMS logs the correct / not correct answers. In your custom module you can hook into the quiz submission and based on the amount of success % made further actions in the system. Does it answer your question? Let us know if any help is needed, would be happy to assist.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Hi, in terms of workaround - well, technically the module doesn't have any smart or complex logic. If you just install the Group module and configure it to have organisations and organisation admins then you'll have almost the same functionality that anu_lms_permission has :-)

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Done - made an official release supporting Drupal 10 πŸ₯³

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Hi @rickyhe0706, thanks for reporting the issue. Can you describe your set up / steps to reproduce? Many thanks in advance.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

@beloglazov91 thanks. Do we know why a paragraph might be null?

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Tested on latest D9 / Anu LMS and could not reproduce the issue. Feel free to re-open if someone will be able to reproduce.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Merged examples into the main branch. Added documentation to https://www.drupal.org/docs/contributed-modules/anu-lms/customising-anu-lms β†’ . Happy to mark the issue as fixed!

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Changed weight.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Updated links to the example modules.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Added relation to the root Anu LMS page.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Bumped compatible Drupal core version.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Slight content change - adding header and removed repeating "Anu LMS" words.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Added initial content.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Hi @ledjerdemain, we've finally had some time to add an example of how to add a custom paragraph type to Anu LMS: https://git.drupalcode.org/issue/anu_lms-3331125/-/tree/3331125-cant-add.... Hopefully you'll find it helpful :-)

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

I've created a MR with an example of how to override the existing component (addressing #8). An example of how to add a new custom paragraph is yet to be added to the same MR.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Hey, I'm sorry it's taking so long to update the documentation. It's still on our TODO list.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Nice work, thanks Alexey

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

Change branch to 7.x, since patch in #174 is for 7.x and needs to be tested by a testbot.

πŸ‡§πŸ‡ΎBelarus Spleshka UAE

I've also tested patch in #174 and confirm that is works like a charm! Thank you.

Production build 0.69.0 2024