Contrib.social

PHP 8.2 Deprecated function: Creation of dynamic property

Open on Drupal.org →
Created on 11 January 2024, 12 months ago

Problem/Motivation

After switching to PHP 8.2 the module started throwing the following errors:

Deprecated function: Creation of dynamic property Drupal\drupalauth4ssp\SspHandler::$config is deprecated in Drupal\drupalauth4ssp\SspHandler->__construct() (line 32 of modules/contrib/drupalauth4ssp/src/SspHandler.php).

Deprecated function: Creation of dynamic property Drupal\drupalauth4ssp\SspHandler::$pathMatcher is deprecated in Drupal\drupalauth4ssp\SspHandler->__construct() (line 33 of modules/contrib/drupalauth4ssp/src/SspHandler.php).

Deprecated function: Creation of dynamic property Drupal\drupalauth4ssp\SspHandler::$request is deprecated in Drupal\drupalauth4ssp\SspHandler->__construct() (line 34 of modules/contrib/drupalauth4ssp/src/SspHandler.php).

This is caused by the properties mentioned in the warning not being defined in SspHandler class before they were used. PHP 8.2 deprecated usage of dynamic properties.

Steps to reproduce

Install the module on Drupal 10 with PHP 8.2. The warning will be displayed on every page request.

Proposed resolution

Define mentioned properties in the class.

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇧🇾Belarus spleshka UAE

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @spleshka
  • Comment 12 months ago →
    🇧🇾Belarus spleshka UAE

    Spleshka → changed the visibility of the branch 3414009-php-8.2-deprecated to hidden.

  • Comment 12 months ago →
    🇧🇾Belarus spleshka UAE

    Spleshka → changed the visibility of the branch 3414009-php-8.2-deprecated to active.

  • Status changed to Needs review 12 months ago
  • Comment 12 months ago →
    🇧🇾Belarus spleshka UAE
  • Merge request !8Resolve #3414009 "PHP 8.2 Deprecated function: Creation of dynamic property" → (Open) created by spleshka
  • Comment 12 months ago →
    🇮🇳India keshavv India
  • Status changed to RTBC 8 months ago
  • Comment 8 months ago →
    🇦🇺Australia realityloop

    This resolves the issue on my project.

  • Comment 8 months ago →
    🇺🇸United States khaldoon_masud

    Could you also include Drupal\drupalauth4ssp\SspHandler::$sspSession property. it is also producing the deprecated warning.

    Deprecated function: Creation of dynamic property Drupal\drupalauth4ssp\SspHandler::$sspSession is deprecated in Drupal\drupalauth4ssp\SspHandler->getSspSession() (line 134 of /code/web/modules/contrib/drupalauth4ssp/src/SspHandler.php

  • Status changed to Needs work 6 months ago
  • Comment 6 months ago →
    🇳🇿New Zealand RoSk0 Wellington

    Recategorising as this is not really a bug.

    Needs work for #8 and rebase on the latest changes in the 2.x branch which now has GitLab CI configured together with the PHPStan.

    PHPStan base line have all the warning that must be resolved, except those two

    1. Access to constant DRUPALAUTH_EXTERNAL on an unknown class
    2. Access to constant DRUPALAUTH_EXTERNAL_USER_ID on an unknown class
  • Comment 6 months ago →
    🇮🇳India samit.310@gmail.com

    samit.310@gmail.com → made their first commit to this issue’s fork.

  • Pipeline finished with Failed
    6 months ago
    Total: 129s
    #226573
  • Pipeline finished with Failed
    6 months ago
    Total: 596s
    #226583
  • Pipeline finished with Canceled
    6 months ago
    #226595
  • Pipeline finished with Failed
    6 months ago
    Total: 140s
    #226598
  • Pipeline finished with Success
    6 months ago
    Total: 128s
    #226607
  • Pipeline finished with Failed
    6 months ago
    Total: 143s
    #226615
  • Pipeline finished with Failed
    6 months ago
    #226626
  • Pipeline finished with Success
    6 months ago
    Total: 133s
    #226630
  • Pipeline finished with Failed
    6 months ago
    Total: 135s
    #226679
  • Pipeline finished with Success
    6 months ago
    Total: 131s
    #226684
  • Status changed to Needs review 6 months ago
  • Comment 6 months ago →
    🇮🇳India samit.310@gmail.com
  • First commit to issue fork.
  • Pipeline finished with Failed
    6 months ago
    Total: 141s
    #228037
  • Pipeline finished with Failed
    6 months ago
    Total: 138s
    #228046
  • Pipeline finished with Success
    6 months ago
    Total: 132s
    #228051
  • Comment 4 months ago →
    🇺🇸United States rex.barkdoll

    I just installed this and it got the error to go away, happy with it working :)

  • Comment 3 months ago →
    🇳🇱Netherlands johan_vm Tilburg

    Made a patch of the latest MR.

  • Comment 3 months ago →
    🇳🇱Netherlands johan_vm Tilburg

    The MR only applies on the dev branch, made another patch for 2.0.0-rc1

  • Comment about 1 month ago →
    🇳🇴Norway fls Trondheim

    #15 worked for me. the warning message seems gone

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024