Multiple warnings related to form build functions

Created on 11 April 2024, 9 months ago

Updated 25 April 2024, 8 months ago

Problem/Motivation

When we configured an ECK entity to use Inline Entity Form (not related to Anu LMS at all), the form started throwing a bunch of warnings:

Warning: Undefined array key "form_id" in anu_lms_field_group_form_process_build_alter() (line 52 of modules/contrib/anu_lms/anu_lms.module).
Warning: Trying to access array offset on value of type null in anu_lms_field_group_form_process_build_alter() (line 52 of modules/contrib/anu_lms/anu_lms.module).
Warning: Undefined array key "form_id" in anu_lms_field_group_form_process_build_alter() (line 52 of modules/contrib/anu_lms/anu_lms.module).
Warning: Trying to access array offset on value of type null in anu_lms_field_group_form_process_build_alter() (line 52 of modules/contrib/anu_lms/anu_lms.module).
Warning: Undefined array key "form_id" in anu_lms_assessments_field_group_form_process_build_alter() (line 147 of modules/contrib/anu_lms/modules/anu_lms_assessments/anu_lms_assessments.module).
Warning: Trying to access array offset on value of type null in anu_lms_assessments_field_group_form_process_build_alter() (line 147 of modules/contrib/anu_lms/modules/anu_lms_assessments/anu_lms_assessments.module).

Looks like a some checks are missing.

Steps to reproduce

- Create a custom entity using ECK module
- Add a ECK entity to any form using Inline Entity Form module
- You'll see the warnings above

Proposed resolution

Add missing checks in place.

User interface changes

No.

API changes

No.

Data model changes

No.

🐛 Bug report

Status

Fixed

Version

2.0

Component

Code

Created by

🇧🇾Belarus spleshka UAE

Live updates comments and jobs are added and updated live.

Merge Requests

!52Multiple warnings related to form build functions
Merged
🇧🇾Belarus spleshka
updated 9 months ago

Comments & Activities

Issue created by @spleshka
Merge request !52Issue #3440147: Fixing form warnings → (Merged) created by spleshka
Comment 9 months ago →
System Message

Spleshka → committed 4240f973 on 2.x
Issue #3440147: Fixing form warnings
Status changed to Fixed 9 months ago9:46am 11 April 2024
Comment 9 months ago →
🇧🇾Belarus spleshka UAE
Comment 9 months ago →
🇮🇳India sarwan_verma
HI @Spleshka,

I have fixed this issue "Multiple warnings related to form build functions" and also attached patch ,
kindly review and verify.
Comment 9 months ago →
🇧🇾Belarus spleshka UAE
Hi @sarwan_verma, appreciate the input! I was a little quicker and already merged PR before you provided a patch, but thanks for your contribution anyway!
Comment 8 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024