Support for IEF ^3

Created on 22 May 2024, 7 months ago
Updated 12 September 2024, 3 months ago

Problem/Motivation

This module's composer.json requires inline_entity_form:^1.0@RC.

It should be required as ^1 || ^3. https://www.drupal.org/project/inline_entity_form/issues/3407711 πŸ“Œ Other projects should require drupal/inline_entity_form ^1 || ^3 Active

Steps to reproduce

Proposed resolution

Update the composer requirement and test 3.x compatibility.

Remaining tasks

User interface changes

API changes

Data model changes

✨ Feature request
Status

Fixed

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States mortona2k Seattle

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mortona2k
  • First commit to issue fork.
  • Assigned to elaman
  • πŸ‡°πŸ‡¬Kyrgyzstan elaman
  • Merge request !58Resolve #3449177 "Support for ief" β†’ (Merged) created by elaman
  • Issue was unassigned.
  • Status changed to Needs review 7 months ago
  • πŸ‡°πŸ‡¬Kyrgyzstan elaman

    Tested version 3:
    - No config changes detected.
    - No database updates between 1 and 3 versions.
    - Assessment (Quiz) module that uses IEF works well with the version 3.

    Updated composer.json to support version 3.

  • What is the status on this please? I ran into the same issue trying to install Anu LMS and having composer want to downgrade IEF.

  • πŸ‡§πŸ‡ΎBelarus spleshka UAE

    @elaman, can you please move CI fixes to another issue, so that we can merge only IEF fix in this issue? I'm worried that otherwise it may take longer to get this in.

  • πŸ‡°πŸ‡¬Kyrgyzstan elaman

    @spleshka done. We had the phpunit issue here https://www.drupal.org/project/anu_lms/issues/3446909 πŸ“Œ CI/CD has failing phpunit step Needs work all along. Would appreciate if anyone is interested in tackling it. Apart from fixing the pipeline itself, would be also good to schedule the automated tests, to catch failing patches.

  • πŸ‡§πŸ‡ΎBelarus spleshka UAE

    Thanks @elaman. Can you please remove changes from PR in this issue not related to the issue as well? It'd help me to merge the changes. Thanks!

  • πŸ‡°πŸ‡¬Kyrgyzstan elaman

    @spleshka done

  • Pipeline finished with Skipped
    4 months ago
    #263308
  • Status changed to Fixed 4 months ago
  • πŸ‡§πŸ‡ΎBelarus spleshka UAE

    Thanks @elaman, merged the MR. Let's solve CI / tests issue separately.

  • running IEF 3, installing the latest release of ANU still gives me the composer error:

    Your requirements could not be resolved to an installable set of packages.
    
      Problem 1
        - drupal/anu_lms[2.10.0, ..., 2.10.2] require drupal/inline_entity_form ^1@RC -> found drupal/inline_entity_form[1.0.0-rc1, ..., 1.0.0-rc17] but it conflicts with your root composer.json require (^3.0@RC).
        - drupal/anu_lms[2.10.3, ..., 2.10.6] require drupal/inline_entity_form ^1.0@RC -> found drupal/inline_entity_form[1.0.0-rc1, ..., 1.0.0-rc17] but it conflicts with your root composer.json require (^3.0@RC).
        - drupal/anu_lms 2.10.7 requires drupal/inline_entity_form ^1.0@RC||3.0@RC -> found drupal/inline_entity_form[1.0.0-rc1, ..., 1.0.0-rc17] but it conflicts with your root composer.json require (^3.0@RC).
        - Root composer.json requires drupal/anu_lms ^2.10 -> satisfiable by drupal/anu_lms[2.10.0, ..., 2.10.7].
    
    
  • πŸ‡§πŸ‡ΎBelarus spleshka UAE

    Hey @nojj, you're absolutely right. There was a typo in the MR.

    It should have been "drupal/inline_entity_form": "^1.0@RC||^3.0@RC" instead of "drupal/inline_entity_form": "^1.0@RC||3.0@RC" (missing ^).

    I've pushed the fix to 2.x and now making a new release. Thank you for reporting the issue!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024