- Issue created by @mortona2k
- First commit to issue fork.
- Assigned to elaman
- Issue was unassigned.
- Status changed to Needs review
7 months ago 10:40am 4 June 2024 - π°π¬Kyrgyzstan elaman
Tested version 3:
- No config changes detected.
- No database updates between 1 and 3 versions.
- Assessment (Quiz) module that uses IEF works well with the version 3.Updated composer.json to support version 3.
What is the status on this please? I ran into the same issue trying to install Anu LMS and having composer want to downgrade IEF.
- π§πΎBelarus spleshka UAE
@elaman, can you please move CI fixes to another issue, so that we can merge only IEF fix in this issue? I'm worried that otherwise it may take longer to get this in.
- π°π¬Kyrgyzstan elaman
@spleshka done. We had the phpunit issue here https://www.drupal.org/project/anu_lms/issues/3446909 π CI/CD has failing phpunit step Needs work all along. Would appreciate if anyone is interested in tackling it. Apart from fixing the pipeline itself, would be also good to schedule the automated tests, to catch failing patches.
- π§πΎBelarus spleshka UAE
Thanks @elaman. Can you please remove changes from PR in this issue not related to the issue as well? It'd help me to merge the changes. Thanks!
-
spleshka β
committed 359a868b on 2.x authored by
elaman β
Issue #3449177: Support for IEF ^3
-
spleshka β
committed 359a868b on 2.x authored by
elaman β
- Status changed to Fixed
4 months ago 8:31am 24 August 2024 - π§πΎBelarus spleshka UAE
Thanks @elaman, merged the MR. Let's solve CI / tests issue separately.
running IEF 3, installing the latest release of ANU still gives me the composer error:
Your requirements could not be resolved to an installable set of packages. Problem 1 - drupal/anu_lms[2.10.0, ..., 2.10.2] require drupal/inline_entity_form ^1@RC -> found drupal/inline_entity_form[1.0.0-rc1, ..., 1.0.0-rc17] but it conflicts with your root composer.json require (^3.0@RC). - drupal/anu_lms[2.10.3, ..., 2.10.6] require drupal/inline_entity_form ^1.0@RC -> found drupal/inline_entity_form[1.0.0-rc1, ..., 1.0.0-rc17] but it conflicts with your root composer.json require (^3.0@RC). - drupal/anu_lms 2.10.7 requires drupal/inline_entity_form ^1.0@RC||3.0@RC -> found drupal/inline_entity_form[1.0.0-rc1, ..., 1.0.0-rc17] but it conflicts with your root composer.json require (^3.0@RC). - Root composer.json requires drupal/anu_lms ^2.10 -> satisfiable by drupal/anu_lms[2.10.0, ..., 2.10.7].
-
spleshka β
committed ce1cf4a4 on 2.x
Issue #3449177 by elaman, spleshka: Support for IEF ^3
-
spleshka β
committed ce1cf4a4 on 2.x
- π§πΎBelarus spleshka UAE
Hey @nojj, you're absolutely right. There was a typo in the MR.
It should have been
"drupal/inline_entity_form": "^1.0@RC||^3.0@RC"
instead of"drupal/inline_entity_form": "^1.0@RC||3.0@RC"
(missing^
).I've pushed the fix to 2.x and now making a new release. Thank you for reporting the issue!
Automatically closed - issue fixed for 2 weeks with no activity.