- Issue created by @elaman
- Open on Drupal.org βCore: 9.5.5 + Environment: PHP 8.0 & MySQL 5.7last update
12 months ago Not currently mergeable. - @elaman opened merge request.
- last update
12 months ago 3 pass - @elaman opened merge request.
- Status changed to Needs review
12 months ago 12:31pm 5 July 2023 - Status changed to Needs work
11 months ago 4:19pm 3 August 2023 - π§πΎBelarus Spleshka UAE
Hi @elaman, thanks for creating an issue. I had a look at the code, here are my thoughts:
- CHANGELOG and README updates are needed to reflect the new feature
- I think the name cookie dummy_email must be improved. It should definitely start with "domino_" to indicate that the cookie is related to the Domino module
- The feature as is poses a security vulnerability. When the module with this feature is enabled on the production site (which is the intention, as I far as I can understand), you can literally start hijacking emails sent by Drupal which were not intended to be sent to your email address. It's very dangerous behavior. You need to think of better way to protect this feature for your use case. - last update
11 months ago 3 pass - last update
11 months ago 3 pass - last update
11 months ago 3 pass - Status changed to Fixed
11 months ago 7:15am 14 August 2023 - π§πΎBelarus Spleshka UAE
Now it's looking great, thanks Elaman! Happy to get it merged.
-
Spleshka β
committed c94daffa on 3.x authored by
elaman β
Issue #3372456 by elaman, Spleshka: Allow replacing the recipients of...
-
Spleshka β
committed c94daffa on 3.x authored by
elaman β
Automatically closed - issue fixed for 2 weeks with no activity.