I'm not really familiar with this module, just exploring it before I decide to use it. It seems to me that any other existing query string is concatenated into the $destination variable that I wrapped in urlencode(). See: https://git.drupalcode.org/issue/r4032login-3441317/-/blob/2.2.x/src/Eve...
I'm not sure if this is the right approach, but if we add a condition to check if there was an existing destination parameter, we can keep it and it will be URL-encoded so that it comes through well.
Why is there a different choice for "Base color" and "Primary color" in the select list if they are the same? It's very confusing.
I read the page you linked to. It does not have the word "base" on it anywhere.
Let me reiterate my question: What does "Base color" refer to? We don't have the option to set a "Base color" in the UI, so where does the value come from?
While I haven't read every reply, I didn't see any results when I searched for ARIA in this issue, so adding my use case.
I got here because I'm trying to manipulate Views output to create accessible Read More links like described at https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA8 wherein I am adding an aria-label attribute with a token like <a href="/node/{{ nid }}" aria-label="Read more about {{ title }}">Read More</a> where the title in this case contains a colon. Everything in the ARIA Label up to and including the colon in the title is stripped.
I reverted to the fix commit from 3.1.0 and it's not fixed.
Error: Call to undefined method Drupal\Core\Database\Transaction::id() in Drupal\gdpr_dump\Service\GdprSqlDump->cleanup() (line 349 of /var/www/html/web/modules/contrib/gdpr/modules/gdpr_dump/src/Service/GdprSqlDump.php).
I just read ✨ Create composer.libraries.json Closed: works as designed and understand this will not be implemented.
Reverting. I don't know how to update a merge request to target a different branch properly.
Changing target branch.
Thank you for posting this. Adding text strings for toolbar and admin_toolbar to help others find it. I spent many hours debugging before actually figuring out a related issue.
> Are you creating a sub-theme of bootstrap_sass?
No, I am not. I stated that in my comment.
> While it is understood that these files will be overwritten when we compile assets for our own subthemes, I think it makes sense to keep them up-to-date for released versions of the theme. I encountered the same issue when installing this theme just to try it out without the extra work of creating a customized version of it.
The fix of adding $barrio_path_images: "../images/"; to the subtheme SCSS works for me. The parent theme works on its own, but using this theme does not without that variable set.
The bundled Font Awesome version (5.12.1) does not include the x-twitter icon which was added in Font Awesome version 6.4.2.
The files in the js/ directory, including js/bootstrap.min.js, have not been recompiled as minimum required versions for the theme have increased. Notice that the version of js/bootstrap.min.js comes from the initial commit over 6 years ago.
While it is understood that these files will be overwritten when we compile assets for our own subthemes, I think it makes sense to keep them up-to-date for released versions of the theme. I encountered the same issue when installing this theme just to try it out without the extra work of creating a customized version of it.
If you aren't willing to keep the compiled assets up to date then putting a notice of some kind in the documentation or on the project page would be helpful. Something like
The compiled assets bundled with this theme are likely out of date. It is highly recommended to run
gulpin order to recompile them before trying out this theme.
would clarify the situation quite a bit.
(The original issue I came looking for is that the dropdown menus in the Admin Toolbar → do not work on the frontend when this theme is in use out of the box.)
Please tag a release for Drupal 10 compatibility.
I've set heading levels in the document for accessibility and automatic section anchors.
for some reason, maybe I typed the answer to the prompt incorrectly, but I needed to manually set
"config": {
"allow-plugins": {
"wikimedia/composer-merge-plugin": true
}
}
because it was set to false when I finally noticed
after a few attempts at recreating the process, it still doesn't seem consistent that I see the message about trusting the plugin
wikimedia/composer-merge-plugin contains a Composer plugin which is currently not in your allow-plugins config. See https://getcomposer.org/allow-plugins
Do you trust "wikimedia/composer-merge-plugin" to execute code and wish to enable it now? (writes "allow-plugins" to composer.json) [y,n,d,?] y
it would have helped me if I had seen a note on this page encouraging me to check the allow-plugins section after requiring wikimedia/composer-merge-plugin
I've added an update hook inspired by 💬 How to install a new entity type from class annotations in an update hook Active .
I'm not sure about the numbering.
One issue that needs addressing is an upgrade path.
On a site with the existing 8.x-3.x module installed, when I patch the module with the code from this MR and run database updates, I see this error on the /admin/reports/status page:
Entity/field definitions
Mismatched entity and/or field definitions
The following changes were detected in the entity type and field definitions.Simple popup blocks
- The Simple popup blocks entity type needs to be installed.
This is a great (huge!) patch. I added the incorporation of another patch 🐛 Warning: htmlspecialchars() expects parameter 1 to be string, array given RTBC which is RTBC.
I'm working on a custom module that contains default config for simple_popup_blocks with a dependency on my module. When using 8.x-3.x the config was not being removed when my module was uninstalled. With this patch I get the expected behavior of the config being removed.
Thanks!
TommyK → created an issue.