add composer.libraries.json file

Created on 1 February 2024, 5 months ago
Updated 7 April 2024, 3 months ago

Problem/Motivation

We need an easy way to install the kenwheeler/slick dependency with composer. The existing issue ✨ Improve composer support Needs work is not quite there.

Proposed resolution

Add a composer.libraries.json file. See the instructions for the Chosen module on installing its dependency: https://git.drupalcode.org/project/chosen/-/blob/4.0.x/README.txt?plain=...

✨ Feature request
Status

Closed: works as designed

Version

2.0

Component

Code

Created by

🇺🇸United States TommyK

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @TommyK
  • Pipeline finished with Success
    5 months ago
    Total: 171s
    #85867
  • 🇺🇸United States TommyK
  • Status changed to Needs review 5 months ago
  • 🇺🇸United States TommyK
  • Status changed to Postponed 5 months ago
  • 🇮🇩Indonesia gausarts

    We appreciated your useful contribution. This sounds better than the linked issue, technically.

    We should close the other issue even if this one is a dup due to no progress in there.

    The only objections I mentioned anywhere so far in those dups are:

    1. Accessible Slick vs. regular Slick vs. working versions.
    2. It will open up security issues in this module. A very low quality of security issues that only add unnecessary noises.

      We didn't want this module or any I maintained to be a snack for script kiddies. Real Drupal developers are not script kiddies, of course, but they are just anywhere I know some of for sure.

      It is public knowledge that third party libraries may contain security holes. Even if you think such a hole is no longer relevant now, Slick library v1 did have it.

      If you don't know such a thing, you are well informed now. I had worked with Slick since 2014 so you have an authoritative reply.

      Whenever we can, we should minimize low quality noise downstream to not leak or crop up to the serious-level upstream, even if it is indeed very useful. Shortly, usefulness must be set aside for seriousness.

    Anyway as I said in the linked issue, due to dups, if you or anyone can elaborate and convince me about those three issues, I am all ears.

    Thank you.

    Note:
    Intentionally postponed due to too many dups. Feel free to re-open you can address the above mentioned issues without being offhanded.

  • Status changed to Closed: works as designed 3 months ago
  • 🇮🇩Indonesia gausarts

    3.x is out.

    Any contribution should refer to the provided docs as outlined at project home:
    https://git.drupalcode.org/project/slick/-/blob/3.0.x/docs/CONTRIBUTION....

  • Status changed to Active 3 months ago
  • 🇺🇸United States TommyK

    Changing target branch.

  • Pipeline finished with Success
    3 months ago
    Total: 160s
    #140166
  • Pipeline finished with Success
    3 months ago
    #140175
  • Status changed to Closed: works as designed 3 months ago
  • 🇺🇸United States TommyK

    Reverting. I don't know how to update a merge request to target a different branch properly.

Production build 0.69.0 2024