- Issue created by @dakhara
- Status changed to Postponed: needs info
about 1 year ago 2:44pm 12 January 2024 - Status changed to Active
about 1 year ago 12:25am 20 February 2024 - 🇺🇸United States tommyk
The files in the
js/
directory, includingjs/bootstrap.min.js
, have not been recompiled as minimum required versions for the theme have increased. Notice that the version ofjs/bootstrap.min.js
comes from the initial commit over 6 years ago.While it is understood that these files will be overwritten when we compile assets for our own subthemes, I think it makes sense to keep them up-to-date for released versions of the theme. I encountered the same issue when installing this theme just to try it out without the extra work of creating a customized version of it.
If you aren't willing to keep the compiled assets up to date then putting a notice of some kind in the documentation or on the project page would be helpful. Something like
The compiled assets bundled with this theme are likely out of date. It is highly recommended to run
gulp
in order to recompile them before trying out this theme.would clarify the situation quite a bit.
(The original issue I came looking for is that the dropdown menus in the Admin Toolbar → do not work on the frontend when this theme is in use out of the box.)
- 🇮🇳India ravi kant Jaipur
@TommyK
Are you creating a sub-theme of bootstrap_sass?I did not find an issue when I ran the gulp command on the bootstrap_sass folder and, I got the 'bootstrap.min.js' version according to bootstrap_sass version.
- 🇺🇸United States tommyk
> Are you creating a sub-theme of bootstrap_sass?
No, I am not. I stated that in my comment.
> While it is understood that these files will be overwritten when we compile assets for our own subthemes, I think it makes sense to keep them up-to-date for released versions of the theme. I encountered the same issue when installing this theme just to try it out without the extra work of creating a customized version of it.
- 🇮🇳India ravi kant Jaipur
Ok @TommyK
I am agree that default compile style files should be upto date with latest compile.
- Status changed to Needs review
about 1 year ago 5:41am 2 April 2024