Bad version of Bootstrap in bootstrap.min.js

Created on 12 January 2024, 6 months ago
Updated 2 April 2024, 3 months ago

Hi,

It seems the version of Bootstrap is Bootstrap 4.0 beta in the file bootstrap.min.js in the js directory, normally it's Bootstrap 5.3.1. I reproduce the problem on the 5.0.10, 5.0.6 and 5.0.5 for the moment. The file cause the issue Bootstrap's JavaScript requires jQuery. jQuery must be included before Bootstrap's JavaScript.

💬 Support request
Status

Needs review

Version

5.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dakhara
  • Status changed to Postponed: needs info 6 months ago
  • 🇵🇪Peru hatuhay Lima
  • Status changed to Active 4 months ago
  • 🇺🇸United States TommyK

    The files in the js/ directory, including js/bootstrap.min.js, have not been recompiled as minimum required versions for the theme have increased. Notice that the version of js/bootstrap.min.js comes from the initial commit over 6 years ago.

    While it is understood that these files will be overwritten when we compile assets for our own subthemes, I think it makes sense to keep them up-to-date for released versions of the theme. I encountered the same issue when installing this theme just to try it out without the extra work of creating a customized version of it.

    If you aren't willing to keep the compiled assets up to date then putting a notice of some kind in the documentation or on the project page would be helpful. Something like

    The compiled assets bundled with this theme are likely out of date. It is highly recommended to run gulp in order to recompile them before trying out this theme.

    would clarify the situation quite a bit.

    (The original issue I came looking for is that the dropdown menus in the Admin Toolbar → do not work on the frontend when this theme is in use out of the box.)

  • 🇮🇳India ravi kant Jaipur

    @TommyK
    Are you creating a sub-theme of bootstrap_sass?

    I did not find an issue when I ran the gulp command on the bootstrap_sass folder and, I got the 'bootstrap.min.js' version according to bootstrap_sass version.

  • 🇺🇸United States TommyK

    > Are you creating a sub-theme of bootstrap_sass?

    No, I am not. I stated that in my comment.

    > While it is understood that these files will be overwritten when we compile assets for our own subthemes, I think it makes sense to keep them up-to-date for released versions of the theme. I encountered the same issue when installing this theme just to try it out without the extra work of creating a customized version of it.

  • 🇮🇳India ravi kant Jaipur

    Ok @TommyK

    I am agree that default compile style files should be upto date with latest compile.

  • Merge request !18Adding compiled files → (Open) created by ravi kant
  • Status changed to Needs review 3 months ago
  • 🇮🇳India ravi kant Jaipur

    I have created MR !18 for compiled styles files.

Production build 0.69.0 2024