Regression: Day view broken

Created on 16 December 2024, 4 months ago

Problem/Motivation

I get a page not found error when clicking dates on a month view (which is the default Action to take if filter value does not validate).

Steps to reproduce

Simplest reproduction: Install a Drupal site. Install Calendar module. Generate nodes. Add view from template Content Authored on Calendar. View the month page. Click a date number that has a node associated. Page not found.

Checkout commit f85f82a40cb505f1da7fa42e967f7b8f298a6781 (one prior to where regression occurs). Try the day page again. It works.

Proposed resolution

Revert something in the 40d51b7225d9e10162d3ac9481b12ed34d5bf1da commit from issue πŸ“Œ Fix DateArgumentWrapper::getArgFormat() to access protected argFormat and provide default values Active .

In the few hours I was banging my head on this one (not realizing I had one version of the site on beta2 and one on beta3), I did notice that I saw a Y-m-d formatted string somewhere that was unexpected, as most of the date formatting I had been expecting was Ymd. Maybe Y-m-d is a bad default (no expertise at all in this codebase, just something that caught my eye as a potentially significant change).

πŸ› Bug report
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States tommyk

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024