- Issue created by @tommyk
- First commit to issue fork.
- πΊπΈUnited States mortona2k Seattle
I created a patch based on what @tommyk called out.
There are 3 formats removed, and a new $formats array with 6 items.
FullDate is missing from the list, and the default is now Y-m-d.
Removing the dashes in the default made it work.
I don't know much about this code either. It may be more appropriate to add FullDate to the $formats array.
- First commit to issue fork.
- π¨π¦Canada joelpittet Vancouver
I see where I overshot there a bit. I am trying to find a way to get this working like D7 with the hyphens in the args.
LMK if the change there which was missing the class comparison for date_fulldateThe default
Y-m-d
is still in\Drupal\views\Plugin\views\argument\Date
But
Ymd
is used in\Drupal\datetime\Plugin\views\argument\FullDate
and\Drupal\views\Plugin\views\argument\FullDate
- πΊπΈUnited States mortona2k Seattle
I don't think this is going to work.
The key that was broken was FullDate, and Y-m-d is what broke it.
Why not 'FullDate' => 'Ymd', if the default is Y-m-d?
- π¨π¦Canada joelpittet Vancouver
@mortona2k good catch, I didn't mean to put that there. Corrected to
Ymd
forFullDate
- π¨π¦Canada joelpittet Vancouver
Just an FYI this is all related to this core issue BTW which is the last one that makes the calendar_datetime sub module or the core patch needed.
π UI fatal caused by views argument handlers no longer can provide their own default argument handling Needs work - πΊπΈUnited States mortona2k Seattle
I already had that core patch in place, possibly an earlier attempt to fix this.
So it's working now without calendar_datetime enabled.
-
joelpittet β
committed f6672bc2 on 8.x-1.x authored by
mortona2k β
Issue #3494136 by joelpittet, mortona2k, tommyk: Regression: Day view...
-
joelpittet β
committed f6672bc2 on 8.x-1.x authored by
mortona2k β
- π¨π¦Canada joelpittet Vancouver
Thanks @mortona2k I have merged that in, I have a couple other things to add before I make another release.
- πΊπΈUnited States tommyk
Thanks everyone! Fast work! I haven't been able to test it myself yet, but looking forward to it. Appreciate the efforts.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
10 days ago 11:49am 8 April 2025