🇺🇦Ukraine @Abyss

bohart → credited Abyss → .

Hi @amateescu, this is a bit strange, if you think that there is a duplicate problem here, then shouldn't you close this issue (child) instead of the parent issue which is described in #2807371: META Support Content Moderation module → ?

Abyss → changed the visibility of the branch 3308035-version_for_drupal10 to active.

Abyss → changed the visibility of the branch 3308035-version_for_drupal10 to hidden.

I updated the library dependencies for the Webform jQueryUI Buttons module.
Now, when using buttons in webforms, their output is correct.

Abyss → created an issue.

dinazaur → credited Abyss → .

Hi @_shY, I added hook_help.
If you have any suggestions/requests, I'll be happy to help you make them.

Hi @_shY, I fixed route for the configuration page.

Abyss → created an issue.

Abyss → created an issue.

Merged last changes.

Hi @_shY, I moved the functionality of blocks to the base class
If you have any suggestions/requests, I'll be happy to help you make them.

Abyss → created an issue.

Hi @_shY, I replaced static calls with Dependency Injection.
If you have any suggestions/requests, I'll be happy to help you make them.

Abyss → changed the visibility of the branch 8.x-2.x to hidden.

So, there is one problem with this module. At the moment, if we try to save an image from an aspx file, or any other file whose link does not contain the file extension, there is a problem with saving this file and creating image styles for it.
The only good option for versions higher than 8 is to rework it for Media.
There is also an option to rewrite the validation for the File module and, accordingly, for ImageStyle.
@Dave Reid, what do you think about this? Maybe you have other suggestions on how we can solve this now?

@aesuk this issue does not apply specifically to adding a widget.
I created a separate task for this 📌 Add a process for creating file name Active .

@AdamPS, I made changes as per the comments in MR and added a deprecated message for MailerPolicyInterface::getCommonAdjusters.
If you have any other suggestions, I will be happy to add them.

Abyss → created an issue.

@bohart I updated to add a replay message to the existing html body and updated the description for the prependBody method.

@bohart I added checking whether the html_body is already in html format and, in this case, adding the reroute text after the body tag.

Abyss → made their first commit to this issue’s fork.

@AdamPS, I added display of TWIG variables in the BodyEmailAdjuster.
But I would like to clarify, from which version it is better to note that getCommonAdjusters is deprecated, and in which version it should be removed?

Updated the title and description as it was misplaced with ✨ Email body policy form should show available TWIG variables Needs work .

Updated the title and description as it was misplaced with ✨ Email body policy form should show available token browser Active .

@bohart I simplified the weight change logic and also added a weight change for WrapAndConvertEmailAdjuster, as this plugin should be executed after RerouteEmailAdjuster.

Abyss → made their first commit to this issue’s fork.

@joevagyok, it may even be possible to simply close this task, since there is no longer any work required here.

Added a messages with instructions for setting up the module with Symfony Mailer.

It seems that this has already been fixed in issue ✨ Support symfony_mailer, which doesn't use hook_mail_alter Fixed .
@bohart, could you please confirm this?

@AdamPS, could you separate these tasks then?

@joevagyok, it seems that this problem was already resolved in another way. But value and end_value are displayed in html_datetime format.
Also, at the moment, I do not see a problem that the date can be displayed in html_datetime format from these fields, and not start_date or end_date, although based on the logic of the module, it should be displayed taking the timezone as well, but it seems that this is not used in the value and end_value fields.

Abyss → made their first commit to this issue’s fork.

Removed redundant description.

Abyss → created an issue.

Please don't do that here.
If you need to update the template for something, or add new regions, you MUST do it in your custom theme.
The issue does not look correct and does not need to be merged into the main branch.

+

@OPTASY, could you please describe this problem in more detail?
I made a sub theme with the command and without any additional movements after reloading the theme list page, I can see it.

This doesn't work quite right for Drupal 10.

Example:

1. We have one content type that is displayed in 2 views with the same view mode.
2. The views are placed on different pages.
3. Create templates for the content from these views.
4. Open page 1 and we have the expected result.
5. Open page 2 and the content that has already been displayed on page 1 is displayed with the template for the first view.

@Sumit Saini This looks like a duplicate of issue [3391120].
Could you confirm this?

Added the default .gitlab-ci.yml.
If necessary, some tasks can be disabled.
For example, since the module does not have phpunit tests, we can disable the phpunit check.
Let me know if we need to make any additional adjustments.

Abyss → created an issue.

If so, let's split it into two tasks and I'll add this functionality tomorrow.

I'm afraid I misunderstood you a bit.
In this context, it makes sense to add it.
Then do we need to add something else in this task?

If I understood correctly, it doesn't seem logical to do this in BodyBuilder.
In this case, the user will still have to write a handler for their own twig tokens, which is similar to creating their own token.
So do you mind if we add only token_types?

However, in this case, this data will be available only at the stages of building an email, which will no longer be valuable to us.
The data about the current EmailBuilder is not contained in the settingsForm stage, and if I understood the existing code correctly, it cannot be contained there.
If I've misunderstood something, please correct me.

Alternatively, we can store these values in the form_state in the PolicyEditForm and retrieve them from the form_state in the BodyEmailAdjuster.
In this case, to display the available tokens by type, we can indeed describe token_types, but I don't see how we can use variables in this context.

@AdamPS, I added the token list display in the BodyEmailAdjuster.
About adding an annotation, it seems impossible at the moment, because Adjusters don't know anything about the place where they are called, namely EmailBuilder. So, we had to abandon this idea.
If you have any other suggestions, I will be happy to add them.

@VladimirAus, sorry for the long answer.
In this case, we can't add dependency injection as there is a problem with it in Drupal at the moment.
Also, it doesn't make sense for us to move Commands under src, since we use autoloader to load the drush command.
You can find more detailed information here:
https://kporras07.com/blog/creating-drush-commands-inside-theme
https://github.com/drush-ops/drush/issues/4685

Also updated the description in README.md.

Abyss → made their first commit to this issue’s fork.

Abyss → made their first commit to this issue’s fork.

It is necessary to update the examples and description, as this documentation uses AccessInterface, which does not contain methods and is planned to be removed in future versions of Drupal.
📌 Deprecate empty AccessInterface and remove usages Needs work

Here we need to update the functionality to the 2.3.x branch.

We need to separate the creation of a reroute notification from the RerouteEmailHandlerPluginBase method "process" into a separate method, since in EmailAdjuster we will be able to set the notification at the postRender stage, not at the build stage.
RTBC

Abyss → made their first commit to this issue’s fork.

Fixed all PHPCS notices.

Moved Project Update Bot changes to 2.2.x branch

Need to move changes to the 2.2.x branch.

Merge update for the 2.2.x branch to resolve the merge issue and restart the tests for verification.

Move the changes to the 2.2.x branch.

Abyss → made their first commit to this issue’s fork.

We need to update and check on the 2.2.x branch

@SebaZ
Yes, I saw it later, I confused this one with a similar task)

Added default .gitlab-ci.yml.

Abyss → made their first commit to this issue’s fork.

In general, the error in this release is not in the use of methods, but in the dependencies on Drupal versions. This needs to be updated.

@VladimirAus I plan to work on it this weekend.
Also, is this a complete description of the task, or will there be some clarifications?

@VladimirAus I plan to work on it this weekend.
Also, is this a complete description of the task, or will there be some clarifications?

Unfortunately, this is not available in this theme.
But this is a good idea of where to develop this theme in the future.

@GuyManDude you can use the progress bar template from the Bootstrap 5 theme at templates/misc/progress-bar.html.twig in your view field template. In the attached file, you can see an example of such a display.
And is your question related to this issue? Because from the information you provided, your field should just look like a progress bar, not be one.
Perhaps you should create a separate issue ticket for this?

The modal.js file is present in the Bootstrap 5 theme at the paths dist/bootstrap/{version}/js/dist and dist/bootstrap/{version}/js/src. And then you can add it wherever you want and use it according to the official Bootstrap 5 documentation.

@ravi kant what version of the theme do you use? 3.0.x-dev?
Because styles are a very delicate thing, and a patch that may apply to one version will not apply to another.

Very strange. I double-checked the patch and everything seems to be working correctly.
@ravi kant could you tell us what you used to apply the patch?

Removed the border for the summary tag.

Updated the table row colors.

This problem does exist if you install Bootstrap5 as an admin theme. So if no one minds, I will try to fix this problem.

@ravi kant

1. Let's wait for a response from the maintainers, because we may need to update the template for details.
2. While we wait, could you please update your patch as it:
   • Not applicable, as it has the wrong path (the path should be from inside the bootstrap5 theme)
   • There is an obvious problem with compiling the styles, as most of the changes are just whitespace.

@VladimirAus, I've moved the changes from body-overflow-3197698-2.patch to the 3.0.x-dev branch and also committed them to scss.

Added composer.json file with dependencies and updated composer.libraries.json.

Abyss → created an issue.

The stable release 5.3.0 is already being used at the moment.
This will be completed in task ✨ Add support for Bootstrap 5.3.0 Fixed .
So this task should be closed.

@VladimirAus & @jannakha, a question for you, maybe we should update the details.html.twig template, because at the moment this template uses classes of the card component, although it looks and performs the functionality of the accordion component.
Or is it simple to update the styles for the summary tag of this template?

1. It is INCORRECT to change styles in dist, as it contains clean files from the Bootstrap theme.
2. It is not correct to update styles only in the css file, as they will be overwritten after compiling the scss styles.
3. You should update not the details component with the class "card", but the summary tag with the class "card-header".

@GuyManDude unfortunately, this problem occurs in all themes when you have a toolbar, as the height for it is calculated using js.
In general, it looks more like a toolbar issue #2542050: Toolbar implementation creates super annoying re-rendering. → .