- Issue created by @bohart
- Assigned to Shreya_98
- Assigned to chetan 11
- š®š³India chetan 11
Hi @bohart
I have fixed all the phpcs issues, attaching the patch for the same. - Status changed to Needs review
over 1 year ago 6:03am 28 September 2023 - Status changed to RTBC
over 1 year ago 6:45am 28 September 2023 - šµšPhilippines clarkssquared
Hi Indranil Roy,
I applied your patch #6 and I confirmed that it fixed the remaining PHPCS issues, please look at the snippet below.
ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml reroute_email FILE: ...ts/d9/d9-local/web/modules/contrib/reroute_email/src/Form/SettingsForm.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 10 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is | | Drupal\Component\Utility\EmailValidatorInterface. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 454ms; Memory: 12MB ā contrib git:(master) ā cd reroute_email ā reroute_email git:(2.2.x) curl https://www.drupal.org/files/issues/2023-09-28/3390121_phpcs_fix_0.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 901 100 901 0 0 3054 0 --:--:-- --:--:-- --:--:-- 3117 patching file 'src/Form/SettingsForm.php' ā reroute_email git:(2.2.x) ā .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml reroute_email ā contrib git:(master) āThank you
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 7:38am 28 September 2023 - šŗš¦Ukraine bohart Lutsk, Ukraine
This module was moved from deprecated DrupalCI to GitlabCI, the tests can't be run on .patch files anymore.
This way (uploading .patch files instead of Merge requests) is deprecated.
This will happen for all modules for the whole drupal-org in the near future.
Please be aware and do not upload .patch files. Merge requests should be created instead.
Thanks!@see:
https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... ā
https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... ā - Assigned to abyss
- Status changed to Active
over 1 year ago 8:01am 28 September 2023 - @chetan-11 opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:26am 28 September 2023 -
bohart ā
committed 58754dec on 2.2.x authored by
chetan 11 ā
Issue #3390121: Fixed all new PHPCS notices.
-
bohart ā
committed 58754dec on 2.2.x authored by
chetan 11 ā
-
bohart ā
committed 5a4a55f8 on 2.1.x authored by
Abyss ā
Issue #3390121: Fixed all new PHPCS notices.
-
bohart ā
committed 5a4a55f8 on 2.1.x authored by
Abyss ā
- Status changed to Fixed
over 1 year ago 8:38am 28 September 2023 - šŗš¦Ukraine bohart Lutsk, Ukraine
Committed to both 2.1.x and 2.2.x. All tests and checks (phpcs/eslint) are green now!
2.1.x - https://git.drupalcode.org/project/reroute_email/-/pipelines/24589/test_...
2.2.x - https://git.drupalcode.org/project/reroute_email/-/pipelines/24588/test_...Thanks.
Automatically closed - issue fixed for 2 weeks with no activity.