- Issue created by @jannakha
- 🇮🇳India vaibhav_arora
I have added fixes and created patch for the above HTML element border issue, and also attached the screenshot for reference.
- Status changed to Needs review
over 1 year ago 10:02am 27 June 2023 - Assigned to abyss
- Status changed to Active
over 1 year ago 7:36pm 1 July 2023 - 🇺🇦Ukraine abyss
1. It is INCORRECT to change styles in dist, as it contains clean files from the Bootstrap theme.
2. It is not correct to update styles only in the css file, as they will be overwritten after compiling the scss styles.
3. You should update not the details component with the class "card", but the summary tag with the class "card-header". - 🇺🇦Ukraine abyss
@VladimirAus & @jannakha, a question for you, maybe we should update the details.html.twig template, because at the moment this template uses classes of the card component, although it looks and performs the functionality of the accordion component.
Or is it simple to update the styles for the summary tag of this template? - Issue was unassigned.
- Status changed to Needs work
over 1 year ago 8:06pm 1 July 2023 - 🇮🇳India ravi kant Jaipur
@abyss if border class 'border-0' will be added directly on details.html.twig then the border of details will be removed. The issue is on collapse due to the summary tag having a border that should remove when the details tag closes so I have created a patch according to it.
- Status changed to Needs review
over 1 year ago 7:59am 3 July 2023 - Status changed to Needs work
over 1 year ago 6:42pm 3 July 2023 - 🇺🇦Ukraine abyss
@ravi kant
- Let's wait for a response from the maintainers, because we may need to update the template for details.
- While we wait, could you please update your patch as it:
- Not applicable, as it has the wrong path (the path should be from inside the bootstrap5 theme)
- There is an obvious problem with compiling the styles, as most of the changes are just whitespace.
- 🇮🇳India ravi kant Jaipur
@Abyss
Adding new patch but whole style files is updated for white space. I have checked with 'sass scss/style.scss css/style.css' and 'npm run build:sass'.
- Status changed to Needs review
over 1 year ago 4:57pm 4 July 2023 - 🇺🇦Ukraine abyss
Very strange. I double-checked the patch and everything seems to be working correctly.
@ravi kant could you tell us what you used to apply the patch? - 🇮🇳India ravi kant Jaipur
@abyss
Copied patch in theme root and apply patch from theme root in terminal using following command.
git apply patch_file.patch
- 🇺🇦Ukraine abyss
@ravi kant what version of the theme do you use? 3.0.x-dev?
Because styles are a very delicate thing, and a patch that may apply to one version will not apply to another. - Status changed to RTBC
over 1 year ago 2:17pm 7 July 2023 - Status changed to Needs work
about 1 year ago 3:09am 15 September 2023 - Status changed to Needs review
about 1 year ago 3:31am 15 September 2023 - @jannakha opened merge request.
- Status changed to RTBC
about 1 year ago 4:05am 15 September 2023 - 🇦🇺Australia VladimirAus Brisbane, Australia
Thank you for MR! 🍰
Looks great! - Status changed to Needs review
about 1 year ago 2:45pm 15 September 2023 - 🇦🇺Australia jannakha Brisbane!
ok! here's a proper solution I think!
- as per #5 by @Abyss - yes, you're correct the template needs to be updated
- I have started moving to CSS variables so we can have good things (like dark mode) and actually implementing things the Bootstrap5 way (now that they're moving to CSS variables too)checkout MR49 - https://git.drupalcode.org/project/bootstrap5/-/merge_requests/49/diffs
HTML component now looks like Bootstrap accordion:
this also will solve issue:
https://www.drupal.org/project/bootstrap5/issues/3380986 🐛 Layout builder block category label not visible with simple block module enabled Closed: duplicate - Status changed to RTBC
about 1 year ago 7:45am 20 September 2023 -
VladimirAus →
committed 234ada25 on 3.0.x
Issue #3337643 by jannakha, Abyss, ravi kant, vaibhav_arora, VladimirAus...
-
VladimirAus →
committed 234ada25 on 3.0.x
- Status changed to Fixed
6 months ago 1:43pm 23 May 2024 -
VladimirAus →
committed 291cb360 on 4.0.x
Issue #3337643 by jannakha, Abyss, ravi kant, vaibhav_arora, VladimirAus...
-
VladimirAus →
committed 291cb360 on 4.0.x
-
VladimirAus →
committed 234ada25 on 4.0.x
Issue #3337643 by jannakha, Abyss, ravi kant, vaibhav_arora, VladimirAus...
-
VladimirAus →
committed 234ada25 on 4.0.x
- Status changed to Needs work
6 months ago 2:44pm 25 May 2024 - 🇦🇺Australia VladimirAus Brisbane, Australia
Reverting. More work needed.
See 🐛 Tabbed fieldgroups broken after update 3.0.11 => 3.0.12 Active . -
VladimirAus →
committed 6a4505a4 on 3.0.x
Issue #3337643 by jannakha, Abyss, ravi kant, vaibhav_arora, VladimirAus...
-
VladimirAus →
committed 6a4505a4 on 3.0.x
-
VladimirAus →
committed b9d060b8 on 4.0.x
Issue #3337643 by jannakha, Abyss, ravi kant, vaibhav_arora, VladimirAus...
-
VladimirAus →
committed b9d060b8 on 4.0.x
-
VladimirAus →
committed 6a4505a4 on 4.0.x
Issue #3337643 by jannakha, Abyss, ravi kant, vaibhav_arora, VladimirAus...
-
VladimirAus →
committed 6a4505a4 on 4.0.x
This solves the problem
scss:
details.card{ summary.card-header{ border-bottom: 0; border-bottom-right-radius: $card-inner-border-radius; border-bottom-left-radius: $card-inner-border-radius; } } details.card[open]{ summary.card-header{ border-bottom: $card-border-width solid $card-border-color; border-bottom-right-radius: 0; border-bottom-left-radius: 0; } }
Or add css to bootstrap5/css/components/details.css
details.card summary.card-header { border-bottom: 0; border-bottom-right-radius: 0.375rem; border-bottom-left-radius: 0.375rem; } details.card[open] summary.card-header { border-bottom: 1px solid rgba(0, 0, 0, 0.175); border-bottom-right-radius: 0; border-bottom-left-radius: 0; }