🇬🇧United Kingdom @danielzigo

Closed. Duplicates https://www.drupal.org/project/coc_forms_auto_export/issues/3286562 📌 Automated Drupal 10 compatibility fixes Fixed

danielzigo → made their first commit to this issue’s fork.

Closing this ticket now. It's been merged into the main repo code.

Hi @froboy. Thanks for your comment. It wasn't long ago that I was made a maintainer of this module after it stopped being maintained for a good while. So, I've been reviewing changes, and after the merge of the changes for this issue, there was one other addition I made that I've asked my colleague to review. Credits would be assigned to you all after that.

Thank you.

danielzigo → made their first commit to this issue’s fork.

Thank you, @apaderno.

Hello @apaderno,

Pardon me for the late response. My week was really busy.

Thank you for adding me as a maintainer, and for your help in this process. I am also planning to add a few colleagues from my company as co-maintainers to leverage our collective expertise and resources effectively. Together, we aim to address existing issues, develop new features, and enhance the overall utility of the module. We are committed to making a positive impact on the module and the community.

If there are any specific guidelines or priorities that come to mind, and I should be aware of as I start, please let me know.

Thank you once again.

Best regards,
Daniel

Thank you very much, @apaderno.

Best regards,
Daniel

I have also messaged the owner directly via the Contact tab, sending a copy of the message to myself, but I haven't heard back.

Thanks @mondrake.

If you run the update from the UI, you'd just get the same error. See screenshot.

danielzigo → created an issue.

Hi @ozwebapps, I hope you're well. Two weeks ago, I, on behalf of my company, expressed interest in maintaining/co-maintaining Webform Auto Exports. I'm reaching out out again as I haven't heard back yet.

I remain very interested in contributing to the Drupal community by maintaining this module, and continuing to support the use of this module. I believe we can offer valuable support and ensure the module continues to thrive. Please let me know if there are any questions or additional information needed from my side.

Thank you. Looking forward to any feedback.

Best wishes

danielzigo → created an issue.

It's unfortunate that this has taken too long to change status. This looks good to me as well. Will change status to RTBC.

@ChrisDarke, I've tested this on 3.0.0-beta1, and I saw the file name change from 'addtocal.ics' to 'Test basic.ics' on the creation of the file. If what I described hasn't been before, it may be the browser (tested on Arc browser). This was when I added the date field to a basic page named 'Test basic page'.

I tested on another basic page named 'Hello world', and noticed that the file name of the ICS file was 'Hello world addtolocal.ics'. I thought that was weird, so I renamed the page to 'Hello world page' and tried again, and this time the file was named 'Hello world.ics'.

If this isn't desired, then maybe a bit of work is necessary.

Setup: D9.5.11, PHP 8.1

I've also tested the patch in #10, and it worked for me.
D9.5.11, PHP 8.1

I refactored it a bit so it's more readable and for Drupal standards.
Please see patch (for 8.x-1.x).

Other than that, I agree with @roaldnel, it would be good for this to be merged soon.

MR created for new feature request (responsive image support):
https://git.drupalcode.org/project/tiny_slider/-/merge_requests/17

I can confirm @gwvoigt → 's observation in comment #46 ✨ Add support for Ckeditor 5 Needs review . I tested patch 42 on a vanilla Drupal 9.5.11 site (PHP 8.1). I observed the same, the difference in the text format config versus when you edit a node and attempt to add a video.

I did try using this patch before my project was updated to Drupal 10, but it wasn't happy with it – so, I couldn't do the core upgrade. Having removed it, it's now a pain trying to get this back.

The patch is good. Any chance this could go into a new release/version soon, please?

Thanks

Patch #36 also worked for me. Drupal 9.5.11, CKEditor 5, PHP 8.1, Video Embed Field 8.x-2.5.
Test video embed also worked.

danielzigo → made their first commit to this issue’s fork.

I've tested the patch and this works, no problems. It's just an update to the info.yml file. This issue has been on Needs review for about a year. Will change the status.

To review comment #13 with patch. Thanks

Adding a patch that could be used on Drupal 9 sites, before upgrading to Drupal 10.