Coding Standards Issues (many)

ipwa → changed the visibility of the branch 3259014-coding-standards-issues to hidden.

ipwa → changed the visibility of the branch 3259014-coding-standards-issues to hidden.

@danielzigo same here... it'd be great to assign credit → to the folks who worked on this.

Hi @froboy. Thanks for your comment. It wasn't long ago that I was made a maintainer of this module after it stopped being maintained for a good while. So, I've been reviewing changes, and after the merge of the changes for this issue, there was one other addition I made that I've asked my colleague to review. Credits would be assigned to you all after that.

Thank you.

I think something has gone awry here since some of these changes have been merged in. I wonder if there was a merge conflict when merging in the recent changes?

When enabling the dev version of the module, we get several errors including:

ParseError: Unmatched '}' in Drupal\Core\Extension\Extension->load() (line 633 of modules/custom/coc_forms_auto_export/coc_forms_auto_export.module).

And when you remove that addition curly brace, it causes the next following functions to break the code. I think this needs reworking. I'm going to create a new issue and a merge request.