Account created on 5 December 2017, over 6 years ago
#

Merge Requests

Recent comments

🇺🇦Ukraine ysamoylenko

The changes have been merged.

Thank you all for your contribution.

🇺🇦Ukraine ysamoylenko

Confirming that the patch works well on Drupal Core 10.2+ and the latest module release.

The changes will be committed soon.

To make token replacement work for media library images you need to configure your media type form and display modes:

Token replacement will work only once you configured a compatible formatter.

There are two formatters available:

  • ImageField Tokens
  • ImageField Tokens: ColorBox

Widgets available:

  • ImageField Tokens
  • ImageField Tokens Widget Crop

The patch works for both widgets and fomatters.

Screenshots for form and display configuration on media type:

Result:

🇺🇦Ukraine ysamoylenko

Hello @justcaldwell,

Are you sure you configured both: Widget and Formatter for the image field for your entity (Display and Form modes)?

Token replacement will work only once you configured a compatible formatter.

There are two formatters available:

  • ImageField Tokens
  • ImageField Tokens: ColorBox

Widgets available:

  • ImageField Tokens
  • ImageField Tokens Widget Crop

Here are screenshots:

You can also configure a predefined token alt/title values for your image field inside its settings:

Hope you find this explanation useful.

Please reply here if you still experiencing any difficulties.

🇺🇦Ukraine ysamoylenko

The changes have been committed.

Thank you all for your contribution.

🇺🇦Ukraine ysamoylenko

The attached patch fixed the issue.

The changes will be committed soon.

🇺🇦Ukraine ysamoylenko

Thank you for the patch and tests.

The changes have been committed.

🇺🇦Ukraine ysamoylenko

Hello community,

Looks like I found the place where we can fix the problem.

For some reason $request object in /core/lib/Drupal/Core/Pager/PagerParameters.php:65 does not contain 'page' property on AJAX requests, that's why we always have current page equals to 0.

The solution is simple, just add a check if the current request is an AJAX request and try to get the 'page' value from the request URI.

Please test my patch, hope it helps.

🇺🇦Ukraine ysamoylenko

The changes have been merged from another MR in 💬 Drupal 10 Fixed

🇺🇦Ukraine ysamoylenko

Please use the 3.0.0-alpha1 release for Drupal 10.

🇺🇦Ukraine ysamoylenko

The new module release will be created soon.

🇺🇦Ukraine ysamoylenko

Hello @dan612. I propose using the latest module version.
It does not require importing places from CSV files and uses https://met.no API.
To add a new place please follow the instructions described in the updated README.md file for 3.x module version.
https://git.drupalcode.org/project/weather/-/blob/3.x/README.md?ref_type...

The further module development will be in the 3.x branch.

🇺🇦Ukraine ysamoylenko

The changes look good to me and will be merged soon. Thank you all for your contribution.

🇺🇦Ukraine ysamoylenko

Thank you all for your contribution the changes will be merged soon.

🇺🇦Ukraine ysamoylenko

Thank you all for your contribution. The MR will be merged into the dev branch soon.

🇺🇦Ukraine ysamoylenko

@gun2dru thank you for providing your test results.

You are right, starting from the module version configuration schema of the module has changed.

As I can see the issue was created on 9 Apr 2019, so a lot of changes were applied to the module from that time.

If you are using an outdated version of the module please create a DB backup before the module upgrade, then pull a new version and run "drush updb", all outdated configurations will be upgraded to the new configuration schema format.

🇺🇦Ukraine ysamoylenko

Module lines have differences since the patch was published but it fixes the deprecations. It will be committed soon.

🇺🇦Ukraine ysamoylenko

The module is already compatible with Drupal Core 8.8 -> 10 starting from 2.x-dev release.

🇺🇦Ukraine ysamoylenko

This issue has been already fixed in the last module release.

🇺🇦Ukraine ysamoylenko

Thank you for the prepared MR, the changes will be merged soon.

🇺🇦Ukraine ysamoylenko

Thank you for the prepared MR and testing. The changes are already applied in the 📌 Fix the issues reported by phpcs Fixed .

🇺🇦Ukraine ysamoylenko

Thank you for implementing and testing the patch. The changes will be committed soon.

🇺🇦Ukraine ysamoylenko

The changes have been committed.

🇺🇦Ukraine ysamoylenko

Thank you for the patch implementation and review activities. The changes will be committed soon.

🇺🇦Ukraine ysamoylenko

Thank you for implementing and reviewing this patch. It will be committed soon.

🇺🇦Ukraine ysamoylenko

Thank you for your efforts in preparing the fixes and review. The changes have been committed.

🇺🇦Ukraine ysamoylenko

Hello, I fixed DI issues in my patch. Please review.

🇺🇦Ukraine ysamoylenko

The changes look good to me. Please commit them.

🇺🇦Ukraine ysamoylenko

The fix for this problem is already available in a release 2.0.9

Please try to re-import places again.

Thank you for reporting the issue.

🇺🇦Ukraine ysamoylenko

Thank you for your efforts spent making this patch.

The patch from 🐛 yr.no/met.no XML api will be closed at beginning of 2021 Fixed has been committed.

The changes are published in a release 2.0.9

Starting from 2.1 we are using an XML version of the forecast from the met.no API.

🇺🇦Ukraine ysamoylenko

The patch has been committed.

The changes are published in a release 2.0.9

Starting from 2.1 we are using an XML version of the forecast from the met.no API.

Unit tests still require to be updated.

🇺🇦Ukraine ysamoylenko

Thanks for the patch for 2.0.x branch.

It will be applied soon. It will also contain the fix for 🐛 This URL is no longer valid Fixed

🇺🇦Ukraine ysamoylenko

The MR code looks good to me. The changes will be merged soon.

🇺🇦Ukraine ysamoylenko

ysamoylenko made their first commit to this issue’s fork.

🇺🇦Ukraine ysamoylenko

The changes have been committed.

🇺🇦Ukraine ysamoylenko

The patch looks good to me. Thanks for implementing it.

🇺🇦Ukraine ysamoylenko

Thank you for reviewing the patch. It has been committed.

🇺🇦Ukraine ysamoylenko

The patch has been committed. A new release will be created soon.

🇺🇦Ukraine ysamoylenko

The patch has been committed. A new release will be created soon.

🇺🇦Ukraine ysamoylenko

Hello @c.moisiadis,

The patch looks good to me.

It will be committed soon.

Thanks everyone for testing and reporting the issue.

🇺🇦Ukraine ysamoylenko

Hello @WannaAlwaysBe,

Thank you for the patch, it looks good to me.

The patch will be committed soon.

🇺🇦Ukraine ysamoylenko

Hello @Rar9, @joshuautley,

This is a feature request, as imagefield_tokens module has no integration with colorbox module image formatter.

However, I've implemented the required plugin for you.

Please test it as a patch first.

To use this new functionality please use ImageField Tokens Widget and ImageField Tokens: Colorbox formatted.

Input:

Output:

So, please review my patch and let me know about the results.

🇺🇦Ukraine ysamoylenko

Confirming that https://www.drupal.org/project/drupal/issues/1149078#comment-14271390 🐛 States API doesn't work with multiple select fields Needs review works correctly with empty values on 9.5.3.

🇺🇦Ukraine ysamoylenko

Hello @Berdir,

Thank you for your response.

These array keys do not exist in the $info array.

I am adding a new patch with a non-empty evaluation.

According to the mentioned issue, it looks similar but for another section of the report.

In our environment, I have not faced it.

🇺🇦Ukraine ysamoylenko

Hello @savel,

Thank you for the patch.

It looks good to me.

Happy to RTBC!

Production build 0.69.0 2024