Fix the issues reported by phpcs

FILE: modules\contrib\map_object_field\assets\css\map-object-field-default-formatter.css --------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" --------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------- FILE: modules\contrib\map_object_field\assets\css\map-object-field-default-widget-config.css ------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------- FILE: modules\contrib\map_object_field\assets\css\map-object-field-default-widget.css ------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------ FILE: modules\contrib\map_object_field\assets\js\map-object-field-default-formatter.js ------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------- FILE: modules\contrib\map_object_field\assets\js\map-object-field-default-widget-config.js ----------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ----------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------- FILE: modules\contrib\map_object_field\assets\js\map-object-field-default-widget.js ---------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ---------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------- FILE: modules\contrib\map_object_field\src\Plugin\Field\FieldFormatter\MapObjectFieldDefaultFormatter.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------- 28 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 52 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead -------------------------------------------------------------------------------------------------------------------------------- FILE: modules\contrib\map_object_field\src\Plugin\Field\FieldWidget\MapObjectFieldDefaultWidget.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 83 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 127 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 201 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 317 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------------------------ FILE: modules\contrib\map_object_field\src\Plugin\views\style\SingleMap.php -------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------- 138 | WARNING | Unused variable $element. 142 | WARNING | Unused variable $index. -------------------------------------------------------------------------------------------------- Time: 7.15 secs; Memory: 14MB

Comments & Activities

Issue created by @ysamoylenko
Comment over 1 year ago →
🇺🇦Ukraine ysamoylenko
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
First commit to issue fork.
@_pratik_ opened merge request.
First commit to issue fork.
Status changed to Needs work over 1 year ago9:32am 16 May 2023
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
The report shows warnings/errors for nine files, but the MR changes only eight files. Either the report is not correct and must be changed, or the MR needs to change only the files for which the report shows warnings/errors.
First commit to issue fork.
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
- * Class MapObjectFieldLib. + * Map Object Field class.
That description is still repeating the class name; it just added spaces. That is not describing what the class does.
@volha_si opened merge request.
Comment over 1 year ago →
Volha_Si
Created pull request to fix warnings like "\Drupal calls should be avoided in classes, use dependency injection instead". Because _pratik_'s MR doesn't fix these warnings.
Status changed to Needs review over 1 year ago7:37am 23 May 2023
Comment over 1 year ago →
🇺🇦Ukraine ysamoylenko
Hello, I fixed DI issues in my patch. Please review.
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Since there is already a MR, it would be better to continue using it.
Comment over 1 year ago →
Volha_Si
The attached patch (#12) looks good for me, please commit the changes.
Status changed to RTBC over 1 year ago8:18am 24 May 2023
Comment over 1 year ago →
Volha_Si
Comment over 1 year ago →
System Message

ysamoylenko → committed 6ad21809 on 2.x
Issue #3359046 by _pratik_, ysamoylenko, Volha_Si, sakthi_dev: Fix the...
Comment over 1 year ago →
🇺🇦Ukraine ysamoylenko
Thank you for your efforts in preparing the fixes and review. The changes have been committed.
Comment over 1 year ago →
System Message
ysamoylenko → closed merge request !2
Status changed to Fixed over 1 year ago8:39am 24 May 2023
Comment over 1 year ago →
System Message
ysamoylenko → closed merge request !1
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Comments & Activities