Account created on 5 August 2008, over 16 years ago
  • Designer / Frontend developer at Marzee Β 
  • Senior Frontend developer at DropsolidΒ 
#

Merge Requests

More

Recent comments

πŸ‡΅πŸ‡ΉPortugal Jolidog

Mian points: show more / show less continues to work
Masonry version loads correctly

All of the above works ith multiple photo gallery blocks on the same page

πŸ‡΅πŸ‡ΉPortugal Jolidog

There could be other ways, cleaner ways of solving this issue, Please check with me before reviewing.

πŸ‡΅πŸ‡ΉPortugal Jolidog

jolidog β†’ created an issue.

πŸ‡΅πŸ‡ΉPortugal Jolidog

Just renamed the templates for now, since we will be refactoring the styleguide soon

πŸ‡΅πŸ‡ΉPortugal Jolidog

Provided a patch.

Relying on some functional js- classes but these are provided by the media-library module it self, so not relying on external templates.

πŸ‡΅πŸ‡ΉPortugal Jolidog

No longer needed after all, seems our current theme stack already regonizes these units

πŸ‡΅πŸ‡ΉPortugal Jolidog

Replaced the rocketship_theme_generator with the rocketship_theme_starter

πŸ‡΅πŸ‡ΉPortugal Jolidog

This is now available on the 3.x branch. Closed the MR against 2.x

πŸ‡΅πŸ‡ΉPortugal Jolidog

$theme_path = drupal_get_path('theme', 'rocketship_theme_starter');
Is handled on https://www.drupal.org/project/rocketship_theme_generator/issues/3368324 πŸ“Œ Replace Classy core theme by contrib theme Fixed

While
$variables['title'] = render($variables['page']['#title']);
Will be handled on https://www.drupal.org/project/rocketship_theme_generator/issues/3375220 πŸ“Œ Remove render function to get page title Fixed

therefor keeping this ticket as fixed

πŸ‡΅πŸ‡ΉPortugal Jolidog

Jolidog β†’ made their first commit to this issue’s fork.

πŸ‡΅πŸ‡ΉPortugal Jolidog

Added empty css files to fix the first compilation issue

πŸ‡΅πŸ‡ΉPortugal Jolidog

Merged this work since it will simplify much of the upcoming work

πŸ‡΅πŸ‡ΉPortugal Jolidog
  • Removed files from all theme versions
  • Added gitkeep files
  • Updated readme file
πŸ‡΅πŸ‡ΉPortugal Jolidog

Jolidog β†’ made their first commit to this issue’s fork.

πŸ‡΅πŸ‡ΉPortugal Jolidog

After internal discussion we decided to remove the demo theme from the generator.

πŸ‡΅πŸ‡ΉPortugal Jolidog

@rembrandx This has been reviewed and tested!

Let's merge it so we can start work on https://www.drupal.org/project/rocketship_theme_generator/issues/3328567 ✨ Simplify the generator. Reduce to 1 variation Fixed

Production build 0.71.5 2024