Merged!
I'm all for removing it
Mian points: show more / show less continues to work
Masonry version loads correctly
All of the above works ith multiple photo gallery blocks on the same page
There could be other ways, cleaner ways of solving this issue, Please check with me before reviewing.
Just renamed the templates for now, since we will be refactoring the styleguide soon
Provided a patch.
Relying on some functional js- classes but these are provided by the media-library module it self, so not relying on external templates.
Jolidog → created an issue.
No longer needed after all, seems our current theme stack already regonizes these units
Replaced the rocketship_theme_generator with the rocketship_theme_starter
This is now available on the 3.x branch. Closed the MR against 2.x
$theme_path = drupal_get_path('theme', 'rocketship_theme_starter');
Is handled on
https://www.drupal.org/project/rocketship_theme_generator/issues/3368324
📌
Replace Classy core theme by contrib theme
Fixed
While
$variables['title'] = render($variables['page']['#title']);
Will be handled on
https://www.drupal.org/project/rocketship_theme_generator/issues/3375220
📌
Remove render function to get page title
Fixed
therefor keeping this ticket as fixed
Added empty css files to fix the first compilation issue
Merged this work since it will simplify much of the upcoming work
- Removed files from all theme versions
- Added gitkeep files
- Updated readme file
After internal discussion we decided to remove the demo theme from the generator.
@rembrandx This has been reviewed and tested!
Let's merge it so we can start work on https://www.drupal.org/project/rocketship_theme_generator/issues/3328567 ✨ Simplify the generator. Reduce to 1 variation Fixed